Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PID] Split tables for tiny and full tune on data #5946

Merged
merged 3 commits into from
May 2, 2024

Conversation

njacazio
Copy link
Collaborator

@njacazio njacazio commented May 2, 2024

No description provided.

@njacazio njacazio marked this pull request as draft May 2, 2024 09:28
@njacazio
Copy link
Collaborator Author

njacazio commented May 2, 2024

@jezwilkinson we realized that now we cannot run anymore the full and tiny tables in the same workflow. This should fix it but it's not perfect. A solution would be to start merging the two workflow into one.
We can decide to rename the full table instead
What do you think?

@jezwilkinson
Copy link
Contributor

@njacazio This seems like a reasonable workaround to me (just for info what does the "Mark<1>" in the "tiny" table do?)
And yes, I think next goal will be to merge the executables to clean this situation up.

@njacazio
Copy link
Collaborator Author

njacazio commented May 2, 2024

It allows to have the same table twice, I think otherwise the metadata will be the same and the compiler will complain that the table is defined twice

@njacazio njacazio marked this pull request as ready for review May 2, 2024 10:33
@alibuild
Copy link
Collaborator

alibuild commented May 2, 2024

Error while checking build/O2Physics/o2 for dcd619e at 2024-05-02 13:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:102: error: 'Mark' is not a member of 'o2::soa'; did you mean 'Marker'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:108: error: template argument 2 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: '<expression error>' in namespace 'o2::soa' does not name a type
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' does not name a type; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:102: error: 'Mark' is not a member of 'o2::soa'; did you mean 'Marker'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:108: error: template argument 2 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: '<expression error>' in namespace 'o2::soa' does not name a type
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' does not name a type; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:19: error: 'mcTPCTuneOnDataTiny' was not declared in this scope; did you mean 'mcTPCTuneOnData'?
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:1: error: template argument 1 is invalid
ninja: build stopped: subcommand failed.

Full log here.

jgrosseo
jgrosseo previously approved these changes May 2, 2024
@jgrosseo jgrosseo enabled auto-merge (squash) May 2, 2024 15:16
@jgrosseo
Copy link
Contributor

jgrosseo commented May 2, 2024

@njacazio This seems like a reasonable workaround to me (just for info what does the "Mark<1>" in the "tiny" table do?) And yes, I think next goal will be to merge the executables to clean this situation up.

And it is called Marker :-D

@njacazio
Copy link
Collaborator Author

njacazio commented May 2, 2024

Thanks @jgrosseo !

@alibuild
Copy link
Collaborator

alibuild commented May 2, 2024

Error while checking build/O2Physics/o2 for f3021b4 at 2024-05-02 20:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/5946-slc7_x86-64/0/Common/DataModel/PIDResponse.h:614:47: error: initializer-string for 'const char [16]' is too long [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

@jgrosseo jgrosseo merged commit fb6992d into AliceO2Group:master May 2, 2024
9 of 10 checks passed
@njacazio njacazio deleted the nj-pidtpctinyfull branch May 3, 2024 07:38
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 7, 2024
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants