Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore <p> tags in table rows #354

Merged
merged 4 commits into from Jan 16, 2024
Merged

Ignore <p> tags in table rows #354

merged 4 commits into from Jan 16, 2024

Conversation

gpanders
Copy link
Contributor

Closes #198

@coveralls
Copy link

coveralls commented Apr 19, 2021 •
edited

Coverage Status

Coverage remained the same at 0.0% when pulling 7fcb2cf on gpanders:no-p-in-table into 6cdb234 on Alir3z4:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.707% when pulling 1d3388d370cce310e01f7d073c87f895c62a1185 on gpanders:no-p-in-table into 4592133 on Alir3z4:master.

peterkajan added a commit to Aidence/html2text that referenced this pull request Aug 18, 2022
@peterkajan
Ignore <p> and <div> inside a table
ad4300a 
Ported Alir3z4#354
This was referenced Aug 18, 2022
Closed
Merged
peterkajan added a commit to Aidence/html2text that referenced this pull request Aug 18, 2022
@peterkajan
Ignore <p> and <div> inside a table (#1)
8778ee1 
* Ignore <p> and <div> inside a table

Ported Alir3z4#354

* fix tests
@dziemich
Copy link

Hello!

We'd love to see this merged and released: currently we're maintaining a fork with that change merged. Could we see this change introduce please? 🙏

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e7cb73) 97.23% compared to head (2a423af) 97.24%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   97.23%   97.24%           
=======================================
  Files          11       11           
  Lines        1122     1124    +2     
=======================================
+ Hits         1091     1093    +2     
  Misses         31       31
Flag Coverage Δ
unittests-3.10 97.24% <100.00%> (+<0.01%) ⬆️
unittests-3.11 97.24% <100.00%> (+<0.01%) ⬆️
unittests-3.12 97.24% <100.00%> (+<0.01%) ⬆️
unittests-3.8 97.24% <100.00%> (+<0.01%) ⬆️
unittests-3.9 97.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alir3z4 Alir3z4 self-requested a review January 16, 2024 17:08
@Alir3z4 Alir3z4 merged commit 7ba8431 into Alir3z4:master Jan 16, 2024
11 checks passed
@Alir3z4 Alir3z4 mentioned this pull request Jan 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alir3z4 Alir3z4 Alir3z4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Ignore <p></p> tags in table
4 participants
@gpanders @coveralls @dziemich @Alir3z4