Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not loading two lib at same time #19

Closed
wants to merge 1 commit into from
Closed

Not loading two lib at same time #19

wants to merge 1 commit into from

Conversation

Darknior
Copy link

@Darknior Darknior commented Dec 7, 2017

Add IF to not load the two lib at same time and crash the MAKE.
Use XMP in first because it give the best sound support with music LOOP.

Add IF to not load the two lib at same time and crash the MAKE.
Use XMP in first because it give the best sound support with music LOOP.
@carstene1ns
Copy link
Collaborator

Not too happy with this situation, the build failure should be solved, yes.
However, I would like to leave ModPlug as default library, partly because of the good license.
(Also it sounds better than xmp to me, i.e. richer sound)

In the future I plan to support even more music libraries: OpenMPT and DUMB. Then this situation gets even worse. For the time being I think some boolean algebra in sound.cpp will suffice.

@Darknior
Copy link
Author

Darknior commented Dec 7, 2017

Like you want, on PI (linux) XMP is better. I think the sound is richer like Modplug because i try the two lib and don't see any difference. Only that Modplug don't loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants