feature: add stop command and recover container #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
reviewed
Nov 1, 2017
apis/server/container_bridge.go
Outdated
| } | ||
|
|
||
| func (s *Server) stopContainer(ctx context.Context, resp http.ResponseWriter, req *http.Request) error { | ||
| t, _ := strconv.Atoi(req.FormValue("t")) |
There was a problem hiding this comment.
I do not think we can ignore the error here. Here is my reason:
This function is handling restful API. If a user uses http pure request "t=asdfg" which is invalid to access daemon, we had better throw out the error rather than make this move on.
daemon/mgr/container.go
Outdated
| } | ||
|
|
||
| // name is the container's prefix of the id. | ||
| if !ok { |
There was a problem hiding this comment.
we can eliminate the if with an else with the above if.
|
Ok, I updated again. @allencloud |
|
Another thing, from the very beginning, is it necessary for us to take #32 into consideration? |
|
About the status code, I agree with you. @allencloud |
"./pouch stop ID" be used to stop a running container. When restart the pouchd, will recover these running containers. Signed-off-by: skoo87 <marckywu@gmail.com>
|
LGTM |
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"./pouch stop ID" be used to stop a running container. When restart the
pouchd, will recover these running containers.
Signed-off-by: skoo87 marckywu@gmail.com