Correct incorrect "archivedir" filesystem permissions #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newly created directories should be created with the eXecute bit set (e.g. 0700). Found and fixed a few calls to mkdir() that were setting mode 0600 (incorrect) instead of the mode 0700 (expected). Also corrected two log messages that were correctly/fully reporting the specific filenames that could not be openned.
The idea here is that we keep the "archivedir" directory permissions at 700 but create the subdirecties as 755 and the [leaf] files as 644. No more errors due to the incorrect directory permissions. Access to the archive starts off locked down but if the node owner opens the "archivedir" permissions then the rest of the content becomes available without having to perform extra chmod's.
Scripts processing the files added to the "archivedir" directory may actually want to remove files that have been processed. Extend the "group" privs to allow removing files. Note: ownership of the "archivedir" dirs/files will be "asterisk:asterisk"
6 tasks
jxmx
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly created directories should be created with the eXecute bit set (e.g. 0700). Found and fixed a few calls to mkdir() that were setting mode 0600 (incorrect) instead of the mode 0700 (expected).
Also corrected two log messages that were correctly/fully reporting the specific filenames that could not be opened.