Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #70 #71

Merged
merged 4 commits into from
Feb 19, 2022
Merged

Fix for #70 #71

merged 4 commits into from
Feb 19, 2022

Conversation

teunbrand
Copy link
Collaborator

This PR should fix #70. For some reason, the method.args argument should be passed through ... and not as its own argument.

@AllanCameron AllanCameron merged commit f11e256 into AllanCameron:main Feb 19, 2022
@AllanCameron
Copy link
Owner

AllanCameron commented Feb 19, 2022

Thanks for that Teun. I had noticed this before but hadn't got round to fixing it. On the subject of bug fixes, systemfonts has been updated to get through the CRAN build. Should we simplify our code by removing the manual fallbacks I had to add in, or keep the messier (but safer) current version?

@teunbrand
Copy link
Collaborator Author

I think simpler is better, but if there is even a slight worry this might come up again in the future, we might as well keep it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geom_textsmooth() doesn't choose method if not explicitly set
2 participants