Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to UNIX EOL #334

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

roryjamesallen
Copy link
Collaborator

When compiling custom uf2 firmware on Windows, an error is thrown which is fixed by opening copy_and_compile.sh in Notepad++ and then going to Edit -> EOL Conversion -> UNIX (LF)

This PR corrects the EOL characters to UNIX to prevent this error, however there may need to be a more robust process for ensuring correct EOL characters are used. It appears a .gitattributes file can be used to make the setting repository-wide, although I don't know if this will interfere with Linux users.

Maybe an addition to troubleshooting.md is more appropriate given the simplicity of the fix, and the fact that it seems the EOL characters can be changed back each time the branch is rebased to main, and the commit often does not register as a commit, but makes the invisible change anyway

@roryjamesallen roryjamesallen added the firmware Software related issue label Feb 9, 2024
Copy link
Collaborator

@mjaskula mjaskula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes seems fine to me.

I've always worked in relatively uniform OS teams, so I don't have any experience with a .gitattributes file or its best practices. I'm open to trying it out though.

@roryjamesallen roryjamesallen merged commit a89878d into Allen-Synthesis:main Feb 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firmware Software related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants