More descriptive scene index error message. #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.00% // Head: 62.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
===========================================
- Coverage 94.00% 62.22% -31.79%
===========================================
Files 46 46
Lines 4021 4021
===========================================
- Hits 3780 2502 -1278
- Misses 241 1519 +1278
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
toloudis
reviewed
Feb 9, 2023
toloudis
approved these changes
Feb 9, 2023
toloudis
approved these changes
Feb 9, 2023
evamaxfield
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
If you read a file with 49 scenes and try to use scene index 49 to get the last one, the error message doesn't make the off-by-one error clear, since 49 is not greater than 49.
The fix
Update the error message
Extra context
This issue came up because the AICS camera alignment service takes the scene index as user input through a web UI -- we should improve that UI, but this can help too.