-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More descriptive scene index error message. #458
Conversation
Codecov ReportBase: 94.00% // Head: 62.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
===========================================
- Coverage 94.00% 62.22% -31.79%
===========================================
Files 46 46
Lines 4021 4021
===========================================
- Hits 3780 2502 -1278
- Misses 241 1519 +1278
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One spelling typo but otherwise this change looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dan caught the typo. Looks good from me though
The issue
If you read a file with 49 scenes and try to use scene index 49 to get the last one, the error message doesn't make the off-by-one error clear, since 49 is not greater than 49.
The fix
Update the error message
Extra context
This issue came up because the AICS camera alignment service takes the scene index as user input through a web UI -- we should improve that UI, but this can help too.