Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/display-first-channel #3

Merged
merged 5 commits into from
Apr 28, 2020
Merged

Conversation

evamaxfield
Copy link
Collaborator

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [admin/build-py39 #12], adds tiff file format support

Resolves #2, always display something on initial load.

  • Provide context of changes.

Balancing heavy initial load and immediate feedback to user, this will make it so that the first channel of an image will be rendered rather than nothing being rendered on initial load of the image.

Additionally, it upgrades the package to using the newly released napari_plugin_engine

  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added the enhancement New feature or request label Apr 28, 2020
@evamaxfield evamaxfield self-assigned this Apr 28, 2020
Copy link
Contributor

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should all work!

napari_aicsimageio/core.py Outdated Show resolved Hide resolved
@evamaxfield evamaxfield merged commit 0201df5 into master Apr 28, 2020
@evamaxfield evamaxfield deleted the feature/display-first-channel branch April 28, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cool! and a question
2 participants