Reformatted using black and adjusted to handle input data location #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much! |
|
Can I ask you to remove the |
|
Sure thing. Sorry, this was my first pull request.
Sam
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Allen Downey ***@***.***>
Sent: Monday, December 12, 2022 11:37:05 PM
To: AllenDowney/ThinkStats2 ***@***.***>
Cc: samuelhutchins ***@***.***>; Author ***@***.***>
Subject: Re: [AllenDowney/ThinkStats2] Reformatted using black and adjusted to handle input data location (PR #198)
Can I ask you to remove the venv directory?
—
Reply to this email directly, view it on GitHub<#198 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADNDY5DLCSKXVERMWW276OLWM4TADANCNFSM6AAAAAAS3PBUAU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
No problem. But before you do, note that I ended up reverting this PR because it makes the notebooks not work on Colab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input files required to run nfsg.py failed as the files are in a subdirectory (code). The thinkstats2.py file was updated to facilitate reading of the input files.
All code files were reformatted with black.