Update setup.py method for retrieving the version of alluxio-py #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current method of specifying the version requires that the user already have the `requests` module installed. This prevents adding this module to any `requirements.txt` file. Since other parts of the system actually use `alluxio.__version__`, I have replaced how `setup.py` gets the current version. Using this mechanism does this with minimal change to the rest of the tools. I have also updated the project homepage to point to the correct Github URL.
Closed
apc999
approved these changes
May 1, 2020
|
Thanks for the fix @pedersen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method of specifying the version requires that the user
already have the
requestsmodule installed. This prevents addingthis module to any
requirements.txtfile.Since other parts of the system actually use
alluxio.__version__,I have replaced how
setup.pygets the current version. Using thismechanism does this with minimal change to the rest of the tools.
I have also updated the project homepage to point to the correct
Github URL.