Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve server-side logging #13736

Merged
merged 2 commits into from
Jul 3, 2021
Merged

Improve server-side logging #13736

merged 2 commits into from
Jul 3, 2021

Conversation

apc999
Copy link
Contributor

@apc999 apc999 commented Jul 2, 2021 •
edited
Loading

What changes are proposed in this pull request?

Simplify the logging based on user feedback

  • Remove excessive logging like “2021-06-01 10:09:25,353 INFO ServerConfigurationChecker - All server-side configurations are consistent.”
  • Add master/worker logging with version
  • Remove noisy logging like WARN EC2MetadataUtils - Unable to retrieve the requested metadata (/latest/meta-data/product-codes). Failed to connect to service endpoint:

Why are the changes needed?

Clean up logging to ease debugging experience

Does this PR introduce any user facing changes?

No

@apc999 apc999 requested a review from yuzhu July 2, 2021 20:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021 •
edited
Loading

Codecov Report

Merging #13736 (2f542ae) into master (efbec94) will increase coverage by 9.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13736      +/-   ##
============================================
+ Coverage     34.70%   43.72%   +9.01%     
- Complexity     6968     9070    +2102     
============================================
  Files          1384     1384              
  Lines         80312    80313       +1     
  Branches       9768     9768              
============================================
+ Hits          27874    35118    +7244     
+ Misses        50039    42259    -7780     
- Partials       2399     2936     +537
Impacted Files Coverage Δ
...ver/common/src/main/java/alluxio/ProcessUtils.java 8.57% <0.00%> (+8.57%) ⬆️
...ter/meta/checkconf/ServerConfigurationChecker.java 80.88% <100.00%> (+67.64%) ⬆️
...main/java/alluxio/worker/AlluxioWorkerProcess.java 68.50% <100.00%> (ø)
...lluxio/client/metrics/MetricsHeartbeatContext.java 77.21% <0.00%> (-3.80%) ⬇️
...in/java/alluxio/worker/block/BlockLockManager.java 77.52% <0.00%> (-1.69%) ⬇️
.../main/java/alluxio/worker/grpc/GrpcDataServer.java 77.52% <0.00%> (-1.13%) ⬇️
...ava/alluxio/multi/process/MultiProcessCluster.java 59.89% <0.00%> (-0.27%) ⬇️
...main/java/alluxio/concurrent/jsr/ForkJoinPool.java 32.16% <0.00%> (-0.11%) ⬇️
...on/src/main/java/alluxio/util/JvmPauseMonitor.java 79.12% <0.00%> (ø)
.../alluxio/master/transport/GrpcMessagingThread.java 80.00% <0.00%> (ø)
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efbec94...2f542ae. Read the comment docs.

yuzhu
yuzhu approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@yuzhu yuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the improvement!

@apc999
Copy link
Contributor Author

apc999 commented Jul 3, 2021

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 1bd9345 into Alluxio:master Jul 3, 2021
bzheng888 pushed a commit to bzheng888/alluxio that referenced this pull request Jul 24, 2021
@apc999
Improve server-side logging
f405631 
### What changes are proposed in this pull request?

Simplify the logging based on user feedback

- Remove excessive logging like “2021-06-01 10:09:25,353 INFO
ServerConfigurationChecker - All server-side configurations are
consistent.”
- Add master/worker logging with version
- Remove noisy logging like `WARN EC2MetadataUtils - Unable to retrieve
the requested metadata (/latest/meta-data/product-codes). Failed to
connect to service endpoint: `

### Why are the changes needed?

Clean up logging to ease debugging experience

### Does this PR introduce any user facing changes?

No

pr-link: Alluxio#13736
change-id: cid-568199789012bc8f2dd53e3feacd1335856e0754
@Xenorith Xenorith mentioned this pull request Apr 18, 2024
Merged
alluxio-bot pushed a commit that referenced this pull request Apr 25, 2024
@Xenorith
Remove noisy logging in InstanceMetadataServiceResourceFetcher
ac3d7cd 
Removes log entries such as `2024-02-13 17:07:02,337 WARN  InstanceMetadataServiceResourceFetcher - Fail to retrieve token` in a similar fashion as #13736
			pr-link: #18580
			change-id: cid-29ce8b283f5905bf3f3e1cab665176dee187e0ff
alluxio-bot pushed a commit that referenced this pull request Apr 25, 2024
@Xenorith @alluxio-bot
Remove noisy logging in InstanceMetadataServiceResourceFetcher
b90b8fc 
Removes log entries such as `2024-02-13 17:07:02,337 WARN  InstanceMetadataServiceResourceFetcher - Fail to retrieve token` in a similar fashion as #13736
			pr-link: #18580
			change-id: cid-29ce8b283f5905bf3f3e1cab665176dee187e0ff
@alluxio-bot alluxio-bot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzhu yuzhu yuzhu approved these changes

Assignees

@ggezer ggezer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apc999 @codecov-commenter @yuzhu @ggezer @alluxio-bot