Fix free worker command bugs #16458
Merged
Fix free worker command bugs #16458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b4c5a1f. Resume branch.
maobaolong
reviewed
Nov 4, 2022
Thanks for your comment! I have added the space. Can you take a look at Fix a bug in WorkerInfoField? Because the |
dbw9580
reviewed
Nov 7, 2022
Add comments in FreeWorker command. Co-authored-by: Bowen Ding <6999708+dbw9580@users.noreply.github.com>
LuQQiu
added
area-shell
elega
approved these changes
Feb 21, 2023
|
alluxio-bot, merge this please |
|
Check evaluation failed: |
|
All checks are green below but checks panel shows that the |
|
Re-opened to trigger all tests again. If the bot still doesn't recognize, i will force merge. |
|
alluxio-bot, merge this please |
YangchenYe323
pushed a commit
to YangchenYe323/alluxio
that referenced
this pull request
Apr 16, 2023
### What changes are proposed in this pull request? Fix potential bugs in freeWorker command. ### Why are the changes needed? When a worker has been decommissioned, its metadata can not be got by calling `getWorkerInfolist()`. This method accesses `LoadingCache<String, List<WorkerInfo>> mWorkerInfoCache` in `DefaultBlockMaster.java`, which will not refresh instantly. As to method `removeDecommissionedWorker()` in `BlockMasterClientServiceHandler.java`, if we don't add FieldRanges, the list `decommissionedWorkers` would not get enough information to run the loop below successfully, though the worker has been decommissioned. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#16458 change-id: cid-101865dc9ec4f40e7561f81f38287c6efc2ae23f
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 16, 2023
### What changes are proposed in this pull request? Fix potential bugs in freeWorker command. ### Why are the changes needed? When a worker has been decommissioned, its metadata can not be got by calling `getWorkerInfolist()`. This method accesses `LoadingCache<String, List<WorkerInfo>> mWorkerInfoCache` in `DefaultBlockMaster.java`, which will not refresh instantly. As to method `removeDecommissionedWorker()` in `BlockMasterClientServiceHandler.java`, if we don't add FieldRanges, the list `decommissionedWorkers` would not get enough information to run the loop below successfully, though the worker has been decommissioned. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#16458 change-id: cid-101865dc9ec4f40e7561f81f38287c6efc2ae23f
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 16, 2023
### What changes are proposed in this pull request? Fix potential bugs in freeWorker command. ### Why are the changes needed? When a worker has been decommissioned, its metadata can not be got by calling `getWorkerInfolist()`. This method accesses `LoadingCache<String, List<WorkerInfo>> mWorkerInfoCache` in `DefaultBlockMaster.java`, which will not refresh instantly. As to method `removeDecommissionedWorker()` in `BlockMasterClientServiceHandler.java`, if we don't add FieldRanges, the list `decommissionedWorkers` would not get enough information to run the loop below successfully, though the worker has been decommissioned. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#16458 change-id: cid-101865dc9ec4f40e7561f81f38287c6efc2ae23f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fix potential bugs in freeWorker command.
Why are the changes needed?
When a worker has been decommissioned, its metadata can not be got by calling
getWorkerInfolist(). This method accessesLoadingCache<String, List<WorkerInfo>> mWorkerInfoCacheinDefaultBlockMaster.java, which will not refresh instantly.As to method
removeDecommissionedWorker()inBlockMasterClientServiceHandler.java, if we don't add FieldRanges, the listdecommissionedWorkerswould not get enough information to run the loop below successfully, though the worker has been decommissioned.Does this PR introduce any user facing changes?
No.