Split BlockStoreEventListener.onCommitBlock() #16777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CommitBlock-break-up
…Listener.java Co-authored-by: elega <445092967@qq.com>
…Listener.java Co-authored-by: elega <445092967@qq.com>
dbw9580
suggested changes
Jan 17, 2023
core/server/worker/src/test/java/alluxio/worker/page/PagedBlockStoreCommitBlockTest.java
Outdated
Show resolved
Hide resolved
core/server/worker/src/test/java/alluxio/worker/page/PagedBlockStoreCommitBlockTest.java
Outdated
Show resolved
Hide resolved
core/server/worker/src/test/java/alluxio/worker/page/PagedBlockStoreCommitBlockTest.java
Outdated
Show resolved
Hide resolved
core/server/worker/src/test/java/alluxio/worker/page/PagedBlockStoreCommitBlockTest.java
Outdated
Show resolved
Hide resolved
core/server/worker/src/test/java/alluxio/worker/page/PagedBlockStoreCommitBlockTest.java
Outdated
Show resolved
Hide resolved
core/server/worker/src/test/java/alluxio/worker/page/PagedBlockStoreCommitBlockTest.java
Outdated
Show resolved
Hide resolved
|
alluxio-bot, merge this please |
jja725
pushed a commit
to jja725/alluxio
that referenced
this pull request
Jan 27, 2023
### What changes are proposed in this pull request? `listener.onCommitBlock()` cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed the `listener.onCommitBlock()` will still be called. This PR separated the `listener.onCommitBlock()` to `onCommitBlockToLocal()` and `onCommitBlockToMaster()`, and added corresponding UT to `PagedBlockStore` and `MonoBlockStore`. ### Why are the changes needed? Please clarify why the changes are needed. For instance, 1. `listener.onCommitBlock()` cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed the `listener.onCommitBlock()` will still be called. The separation of the `listener.onCommitBlock()` can eliminate this inconsistency. ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including No user-facing changes previous conversation is [here](voddle#1) since I select incorrect base repo the first time I create this PR... pr-link: Alluxio#16777 change-id: cid-9c367b0cab5dd5347eda873bc3c8ba189626cc75
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 15, 2023
`listener.onCommitBlock()` cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed the `listener.onCommitBlock()` will still be called. This PR separated the `listener.onCommitBlock()` to `onCommitBlockToLocal()` and `onCommitBlockToMaster()`, and added corresponding UT to `PagedBlockStore` and `MonoBlockStore`. Please clarify why the changes are needed. For instance, 1. `listener.onCommitBlock()` cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed the `listener.onCommitBlock()` will still be called. The separation of the `listener.onCommitBlock()` can eliminate this inconsistency. Please list the user-facing changes introduced by your change, including No user-facing changes previous conversation is [here](voddle#1) since I select incorrect base repo the first time I create this PR... pr-link: Alluxio#16777 change-id: cid-9c367b0cab5dd5347eda873bc3c8ba189626cc75
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 15, 2023
`listener.onCommitBlock()` cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed the `listener.onCommitBlock()` will still be called. This PR separated the `listener.onCommitBlock()` to `onCommitBlockToLocal()` and `onCommitBlockToMaster()`, and added corresponding UT to `PagedBlockStore` and `MonoBlockStore`. Please clarify why the changes are needed. For instance, 1. `listener.onCommitBlock()` cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed the `listener.onCommitBlock()` will still be called. The separation of the `listener.onCommitBlock()` can eliminate this inconsistency. Please list the user-facing changes introduced by your change, including No user-facing changes previous conversation is [here](voddle#1) since I select incorrect base repo the first time I create this PR... pr-link: Alluxio#16777 change-id: cid-9c367b0cab5dd5347eda873bc3c8ba189626cc75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
listener.onCommitBlock()cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed thelistener.onCommitBlock()will still be called. This PR separated thelistener.onCommitBlock()toonCommitBlockToLocal()andonCommitBlockToMaster(), and added corresponding UT toPagedBlockStoreandMonoBlockStore.Why are the changes needed?
Please clarify why the changes are needed. For instance,
listener.onCommitBlock()cannot reflect the state difference between commitBlockToLocal and commitBlockToMaster, so some times when commitBlockToMaster failed thelistener.onCommitBlock()will still be called. The separation of thelistener.onCommitBlock()can eliminate this inconsistency.Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including
No user-facing changes
previous conversation is here since I select incorrect base repo the first time I create this PR...