Fix Worker.ActiveClients is negative when load from ufs #16784
Conversation
|
Maybe I can find why Worker.ActiveClients is a big int too. I'll try. |
|
@flaming-archer Are you still trying to figure out something, or this is ready to be reviewed? |
Sorry for later reply cause of CNY. Yes, I think this is ready to be reviewed. This method will be invoked by download command. And will decrease Worker.ActiveClients, but not increase firstly. |
core/server/worker/src/main/java/alluxio/worker/block/MonoBlockStore.java
Show resolved
Hide resolved
core/server/worker/src/main/java/alluxio/worker/block/MonoBlockStore.java
Show resolved
Hide resolved
|
@flaming-archer @jja725 Just a question, is there something wrong if some clients didn't close the reader normally? Will the Active client metric show the wrong value? |
yes it would show wrong value in your case. Maybe we can have another PR to fix that. |
|
In our environment, 'Worker.ActiveClients' is often a large value. I think that to fix this problem, we maybe can refer to the design of audit log to unify the entrance and exit. @flaming-archer @jja725 |
|
I think this can be merged. |
|
alluxio-bot, merge this please |
### What changes are proposed in this pull request? Fix Worker.ActiveClients is negative when load from ufs ### Why are the changes needed? Please clarify why the changes are needed. For instance, createUfsBlockReader will invoke closeUfsBlock then invoke commitBlock then this metric decrease. But forget to increase firstly . So it need to increase firstly. ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including no. pr-link: Alluxio#16784 change-id: cid-13d0875dc42336cc612dfed121bba8572164ed60
### What changes are proposed in this pull request? Fix Worker.ActiveClients is negative when load from ufs ### Why are the changes needed? Please clarify why the changes are needed. For instance, createUfsBlockReader will invoke closeUfsBlock then invoke commitBlock then this metric decrease. But forget to increase firstly . So it need to increase firstly. ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including no. pr-link: Alluxio#16784 change-id: cid-13d0875dc42336cc612dfed121bba8572164ed60
### What changes are proposed in this pull request? Fix Worker.ActiveClients is negative when load from ufs ### Why are the changes needed? Please clarify why the changes are needed. For instance, createUfsBlockReader will invoke closeUfsBlock then invoke commitBlock then this metric decrease. But forget to increase firstly . So it need to increase firstly. ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including no. pr-link: Alluxio#16784 change-id: cid-13d0875dc42336cc612dfed121bba8572164ed60
What changes are proposed in this pull request?
Fix Worker.ActiveClients is negative when load from ufs
Why are the changes needed?
Please clarify why the changes are needed. For instance,
createUfsBlockReader will invoke closeUfsBlock then invoke commitBlock then this metric decrease.
But forget to increase firstly . So it need to increase firstly.
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including
no.