Support list files through RESTful API #17685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunxuTang
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM for the initial testing.
@JiamingMai Thanks for your nice work!
Meanwhile, @LuQQiu would you mind also having a quick look at this API code change? We could update our Python client-side code to use this API for listing directories.
| * See the NOTICE file distributed with this work for information regarding copyright ownership. | ||
| */ | ||
|
|
||
| package alluxio.worker.http; |
There was a problem hiding this comment.
Thanks for also adding a unit test.
LuQQiu
reviewed
Jul 6, 2023
| switch (requestMapping) { | ||
| case "page": | ||
| return doGetPage(parametersMap, channel, httpRequest); | ||
| case "files": |
There was a problem hiding this comment.
@JiamingMai can it be "list" or other keywords since the directory may contain all subdir?
LuQQiu
approved these changes
Jul 6, 2023
|
This is an exciting feature! Do you have any plans to support more file attributes, such as length and last modification time? |
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support list files through RESTful API
Usage example:
HTTP GET request http://localhost:28080/files?path=/test
lsfiles of the path/testand response a JSON string