Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respond with unsupported message when Ge...; Port [#18416] to branch-2.8 #18432

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Respond with unsupported message when Ge...; Port [#18416] to branch-2.8 #18432

merged 1 commit into from
Nov 22, 2023

Conversation

alluxio-bot
Copy link
Contributor

What changes are proposed in this pull request?

Respond with unsupported message when GetBucketLocation

Why are the changes needed?

Alluxio proxy doesn't support GetBucketLocation request, so we need to return 'Not Implemented' error code.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

[This is an auto-generated PR to cherry-pick committed PR #18416 into target branch branch-2.8]

@Jackson-Wang-7 @alluxio-bot
Respond with unsupported message when GetBucketLocation
0909f3a 
### What changes are proposed in this pull request?
Respond with unsupported message when GetBucketLocation

### Why are the changes needed?
Alluxio proxy doesn't support GetBucketLocation request, so we need to return 'Not Implemented' error code.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

			pr-link: #18416
			change-id: cid-05c70148361e293e6583ddb6abda93eb2c530496
@alluxio-bot alluxio-bot added the type-bug This issue is about a bug label Nov 21, 2023
@alluxio-bot alluxio-bot mentioned this pull request Nov 21, 2023
Merged
@Jackson-Wang-7
Copy link
Contributor

the flaky test can run successfully on my env, just skip them and force merge this PR.

image

@Jackson-Wang-7
Copy link
Contributor

alluxio-bot, force-merge this please

@alluxio-bot
Copy link
Contributor Author

merge failed:
Merge refused because a force command was issued but the github user is not in the admin maintainer list.

@jiacheliu3
Copy link
Contributor

the failing flaky tests are:

2023-11-22T02:03:54.1222252Z 02:03:54.121 [ERROR] Errors: 
2023-11-22T02:03:54.1223818Z 02:03:54.121 [ERROR] alluxio.master.journal.raft.SnapshotReplicationManagerTest.copySnapshotToLeader
2023-11-22T02:03:54.1226602Z 02:03:54.121 [ERROR]   Run 1: SnapshotReplicationManagerTest.copySnapshotToLeader:214 » Timeout Timed out wa...
2023-11-22T02:03:54.1244402Z 02:03:54.122 [ERROR]   Run 2: SnapshotReplicationManagerTest.copySnapshotToLeader:214 » Timeout Timed out wa...
2023-11-22T02:03:54.1246512Z 02:03:54.122 [INFO] 
2023-11-22T02:03:54.1247960Z 02:03:54.122 [ERROR] alluxio.master.journal.raft.SnapshotReplicationManagerTest.failFailThenSuccess
2023-11-22T02:03:54.1250263Z 02:03:54.123 [ERROR]   Run 1: SnapshotReplicationManagerTest.failFailThenSuccess:321 » Timeout Timed out wai...
2023-11-22T02:03:54.1252526Z 02:03:54.123 [ERROR]   Run 2: SnapshotReplicationManagerTest.failFailThenSuccess:321 » Timeout Timed out wai...
2023-11-22T02:03:54.1253845Z 02:03:54.123 [INFO] 
2023-11-22T02:03:54.1258937Z 02:03:54.123 [ERROR] alluxio.master.journal.raft.SnapshotReplicationManagerTest.failGetInfoEqualTermHigherIndex
2023-11-22T02:03:54.1264576Z 02:03:54.124 [ERROR]   Run 1: SnapshotReplicationManagerTest.failGetInfoEqualTermHigherIndex:267 » Timeout T...
2023-11-22T02:03:54.1266892Z 02:03:54.124 [ERROR]   Run 2: SnapshotReplicationManagerTest.failGetInfoEqualTermHigherIndex:267 » Timeout T...
2023-11-22T02:03:54.1268640Z 02:03:54.124 [INFO] 
2023-11-22T02:03:54.1270127Z 02:03:54.124 [ERROR] alluxio.master.journal.raft.SnapshotReplicationManagerTest.failSnapshotRequestEqualTermHigherIndex
2023-11-22T02:03:54.1273440Z 02:03:54.125 [ERROR]   Run 1: SnapshotReplicationManagerTest.failSnapshotRequestEqualTermHigherIndex:288 » Timeout
2023-11-22T02:03:54.1274724Z 02:03:54.125 [ERROR]   Run 2: SnapshotReplicationManagerTest.failSnapshotRequestEqualTermHigherIndex:288 » Timeout
2023-11-22T02:03:54.1275439Z 02:03:54.125 [INFO] 
2023-11-22T02:03:54.1276179Z 02:03:54.125 [ERROR] alluxio.master.journal.raft.SnapshotReplicationManagerTest.installSnapshotsInSuccession
2023-11-22T02:03:54.1277897Z 02:03:54.125 [ERROR]   Run 1: SnapshotReplicationManagerTest.installSnapshotsInSuccession:362 » Timeout Time...
2023-11-22T02:03:54.1279110Z 02:03:54.126 [ERROR]   Run 2: SnapshotReplicationManagerTest.installSnapshotsInSuccession:362 » Timeout Time...

2023-11-22T02:03:54.1116203Z 02:03:54.101 [ERROR] alluxio.master.journal.raft.SnapshotReplicationManagerTest.copySnapshotToLeader  Time elapsed: 30.022 s  <<< ERROR!
2023-11-22T02:03:54.1117891Z java.util.concurrent.TimeoutException: Timed out waiting for leader snapshot to complete options: WaitForOptions{interval=20, timeout=30000} last value: false
2023-11-22T02:03:54.1118913Z 	at alluxio.util.CommonUtils.waitForResult(CommonUtils.java:384)
2023-11-22T02:03:54.1119508Z 	at alluxio.util.CommonUtils.waitFor(CommonUtils.java:342)
2023-11-22T02:03:54.1120460Z 	at alluxio.master.journal.raft.SnapshotReplicationManagerTest.copySnapshotToLeader(SnapshotReplicationManagerTest.java:214)
2023-11-22T02:03:54.1121522Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-11-22T02:03:54.1122432Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2023-11-22T02:03:54.1123471Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-11-22T02:03:54.1124295Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2023-11-22T02:03:54.1125008Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2023-11-22T02:03:54.1125863Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2023-11-22T02:03:54.1126726Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2023-11-22T02:03:54.1127586Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2023-11-22T02:03:54.1128407Z 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
2023-11-22T02:03:54.1129149Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-11-22T02:03:54.1129833Z 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
2023-11-22T02:03:54.1130502Z 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
2023-11-22T02:03:54.1131247Z 	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
2023-11-22T02:03:54.1131986Z 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
2023-11-22T02:03:54.1132731Z 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
2023-11-22T02:03:54.1133736Z 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
2023-11-22T02:03:54.1134457Z 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
2023-11-22T02:03:54.1135077Z 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
2023-11-22T02:03:54.1135733Z 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
2023-11-22T02:03:54.1136396Z 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
2023-11-22T02:03:54.1137031Z 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
2023-11-22T02:03:54.1137667Z 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
2023-11-22T02:03:54.1138276Z 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
2023-11-22T02:03:54.1138992Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
2023-11-22T02:03:54.1139871Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:289)
2023-11-22T02:03:54.1140806Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
2023-11-22T02:03:54.1141680Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
2023-11-22T02:03:54.1142555Z 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
2023-11-22T02:03:54.1143401Z 	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
2023-11-22T02:03:54.1144337Z 	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
2023-11-22T02:03:54.1145096Z 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)

@jiacheliu3
Copy link
Contributor

alluxio-bot, force-merge this please

@alluxio-bot alluxio-bot merged commit b6f99f6 into branch-2.8 Nov 22, 2023
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-bug This issue is about a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alluxio-bot @Jackson-Wang-7 @jiacheliu3