Allow MetricAccountingBlockReader to accept any BlockReader #18590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kai-Zhang
approved these changes
Apr 25, 2024
|
alluxio-bot, merge this please |
|
alluxio-bot, cherry-pick this to branch-2.10 please |
alluxio-bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
generalize the constructor input of MetricAccountingBlockReader to count metrics for any implementation of BlockReader pr-link: #18590 change-id: cid-75519680da58b580045de2496263c26160c07857
|
Auto cherry-pick to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generalize the constructor input of MetricAccountingBlockReader to count metrics for any implementation of BlockReader