Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 when head the file end with slash #18602

Merged
merged 1 commit into from
May 10, 2024

Conversation

Jackson-Wang-7
Copy link
Contributor

@Jackson-Wang-7 Jackson-Wang-7 commented May 9, 2024

What changes are proposed in this pull request?

if the request ends with "/" and the object is a file, return 404

Why are the changes needed?

if the user want to get the metadata of a file, it should not end with "/". if the user wants to get the metadata of a dir, then it should end with "/".

Does this PR introduce any user facing changes?

no

Copy link
Contributor

@humengyu2012 humengyu2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackson-Wang-7 Jackson-Wang-7 added the type-bug This issue is about a bug label May 10, 2024
@Jackson-Wang-7
Copy link
Contributor Author

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 30fc5fb into Alluxio:master-2.x May 10, 2024
19 checks passed
@Jackson-Wang-7
Copy link
Contributor Author

alluxio-bot, cherry-pick this to branch-2.10 please

alluxio-bot pushed a commit that referenced this pull request May 10, 2024
### What changes are proposed in this pull request?
if the request ends with "/" and the object is a file, return 404

### Why are the changes needed?
if the user want to get the metadata of a file, it should not end with "/". if the user wants to get the metadata of a dir, then it should end with "/".

### Does this PR introduce any user facing changes?
no

			pr-link: #18602
			change-id: cid-beaeba5de7ceb9b7ed0d92ad2a171f3ef8523e9d
@alluxio-bot
Copy link
Contributor

Auto cherry-pick to branch branch-2.10 successfully opened PR: #18603

alluxio-bot added a commit that referenced this pull request May 10, 2024
Cherry-pick of existing commit.
orig-pr: #18602
orig-commit: 30fc5fb
orig-commit-author: yuyang wang <39869597+Jackson-Wang-7@users.noreply.github.com>

			pr-link: #18603
			change-id: cid-beaeba5de7ceb9b7ed0d92ad2a171f3ef8523e9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants