[ALLUXIO-2397] Add support for alluxio with Minio. #4217

harshavardhana · 2016-10-22T00:14:31Z

This patch brings in two new options to alluxio-site.properties

UNDERFS_S3A_REGION to be able to provide custom regions.
UNDERFS_S3A_ENABLE_ACL to disable inheriting bucket ACLs

This patch also adds support for s3a driver to honor disabling dns.buckets

A sample configuration looks like this

Fixes https://alluxio.atlassian.net/browse/ALLUXIO-2397

alluxio.underfs.address=s3a://testbucket/
alluxio.underfs.s3.disable.dns.buckets=true
alluxio.underfs.s3.endpoint=http://localhost:9000
alluxio.underfs.s3a.region="us-east-1"
alluxio.underfs.s3a.enable.acl=false
aws.accessKeyId=USWUXHGYZQYFYFFIT3RE
aws.secretKey=MOJRH0mkL1IPauahWITSVvyDrQbEEIwljvmxdq03

alluxio-bot · 2016-10-22T00:14:32Z

Hi @harshavardhana, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

alluxio-bot · 2016-10-22T00:14:32Z

Running checks...

Valid pull request title: false
- Pull request titles should either start with [SMALLFIX], [DOCFIX], or [ALLUXIO-####], see http://www.alluxio.org/docs/master/en/Contributing-to-Alluxio.html#submitting-code
Commits associated with Github account: true

Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks

AmplabJenkins · 2016-10-22T00:16:01Z

Can one of the admins verify this patch?

alluxio-bot · 2016-10-22T00:18:57Z

You did it @harshavardhana!

Thank you for signing the Contribution License Agreement.

alluxio-bot · 2016-10-22T00:26:56Z

Running checks...

Valid pull request title: true
Contains JIRA link: false
- Pull request body should contain a link back to the appropriate JIRA ticket (https://alluxio.atlassian.net/browse/ALLUXIO-2397)
Commits associated with Github account: true

Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks

alluxio-bot · 2016-10-22T00:27:45Z

Running checks...

Valid pull request title: true
Contains JIRA link: false
- Pull request body should contain a link back to the appropriate JIRA ticket (https://alluxio.atlassian.net/browse/ALLUXIO-2397)
Commits associated with Github account: true

Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks

harshavardhana · 2016-10-22T00:34:08Z

alluxio-bot, check this please

alluxio-bot · 2016-10-22T00:34:09Z

Running checks...

Valid pull request title: true
Contains JIRA link: true
Commits associated with Github account: true

All checks passed!

harshavardhana · 2016-10-22T00:35:51Z

Another sample config without setting up a local Minio instance. One can use our public server.

alluxio.underfs.address=s3a://testbucket/

alluxio.underfs.s3.disable.dns.buckets=true
alluxio.underfs.s3.endpoint=https://play.minio.io:9000
alluxio.underfs.s3a.region="us-east-1"
alluxio.underfs.s3a.enable.acl=false
aws.accessKeyId=Q3AM3UQ867SPQQA43P2F
aws.secretKey=zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG

aaudiber · 2016-10-22T19:29:09Z

ok to test

aaudiber · 2016-10-22T19:29:14Z

Jenkins, test this please

AmplabJenkins · 2016-10-22T19:52:23Z

Merged build finished. Test PASSed.

AmplabJenkins · 2016-10-22T19:52:23Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12000/
Test PASSed.

alluxio-bot · 2016-10-22T19:52:25Z

Running checks...

Valid pull request title: true
Contains JIRA link: true
Commits associated with Github account: true

All checks passed!

gpang

@harshavardhana Thanks! I left some comments.

gpang · 2016-10-23T03:40:29Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

-    }
-    String accountOwner = owner == null ? accountOwnerId : owner;
+     // Default to readable and writable by the user.
+    short bucketMode = (short) 0 | (short) 0500 | (short) 0200;


Why is this written this way? Is this equivalent to 700?

yes it is supposed 700

gpang · 2016-10-23T03:42:01Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

@@ -149,29 +152,56 @@ public static S3AUnderFileSystem createInstance(AlluxioURI uri) {
    }

    AmazonS3Client amazonS3Client = new AmazonS3Client(credentials, clientConf);
+    // Set your endpoint.


NIT: instead of saying "your" you can say "Set the custom endpoint".

Also, could you put that within the if statement?

gpang · 2016-10-23T03:43:06Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

    if (Configuration.containsKey(PropertyKey.UNDERFS_S3_ENDPOINT)) {
      amazonS3Client.setEndpoint(Configuration.get(PropertyKey.UNDERFS_S3_ENDPOINT));
    }
+    // Set your region, primary useful for s3 compliant endpoints


NIT: don't use "your". Also, move it within the if block.

gpang · 2016-10-23T03:44:11Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

+    // Set your region, primary useful for s3 compliant endpoints
+    // with custom regions.
+    if (Configuration.containsKey(PropertyKey.UNDERFS_S3A_REGION)) {
+      if (Configuration.get(PropertyKey.UNDERFS_S3A_REGION).equals("us-east-1")) {


why is us-east-1 special? what about other regions?

gpang · 2016-10-23T03:44:12Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

+        amazonS3Client.setRegion(usEast1);
+      }
+    }
+    // Disable DNS style buckets, this enables path style primary useful for


NIT: move this comment within the if block.

gpang · 2016-10-23T03:44:50Z

core/common/src/main/java/alluxio/PropertyKey.java

@@ -78,6 +78,8 @@
  UNDERFS_S3_THREADS_MAX(Name.UNDERFS_S3_THREADS_MAX, 22),
  UNDERFS_S3_UPLOAD_THREADS_MAX(Name.UNDERFS_S3_UPLOAD_THREADS_MAX, 2),
  UNDERFS_S3A_CONSISTENCY_TIMEOUT_MS(Name.UNDERFS_S3A_CONSISTENCY_TIMEOUT_MS, 60000),
+  UNDERFS_S3A_REGION(Name.UNDERFS_S3A_REGION, "us-east-1"),


Previously, this did not exist. Therefore, shouldn't the default be null or empty?

harshavardhana · 2016-10-23T06:53:35Z

@harshavardhana Thanks! I left some comments.

@gpang thanks for your review. Addressed your comments.. Don't need REGION option so removed it one less option.

AmplabJenkins · 2016-10-23T06:58:42Z

Merged build finished. Test FAILed.

AmplabJenkins · 2016-10-23T06:58:43Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12014/

Build result: FAILURE

[...truncated 1235 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3/target/alluxio-underfs-s3-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-s3/1.4.0-SNAPSHOT/alluxio-underfs-s3-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/assembly/pom.xml to org.alluxio/alluxio-assemblies/1.4.0-SNAPSHOT/alluxio-assemblies-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.4.0-SNAPSHOT/alluxio-shell-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/oss/pom.xml to org.alluxio/alluxio-underfs-oss/1.4.0-SNAPSHOT/alluxio-underfs-oss-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/oss/target/alluxio-underfs-oss-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-oss/1.4.0-SNAPSHOT/alluxio-underfs-oss-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/oss/target/alluxio-underfs-oss-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-oss/1.4.0-SNAPSHOT/alluxio-underfs-oss-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/pom.xml to org.alluxio/alluxio-keyvalue-client/1.4.0-SNAPSHOT/alluxio-keyvalue-client-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.4.0-SNAPSHOT/alluxio-underfs-hdfs-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.4.0-SNAPSHOT/alluxio-underfs-hdfs-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.4.0-SNAPSHOT/alluxio-underfs-hdfs-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.4.0-SNAPSHOT/alluxio-underfs-swift-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.4.0-SNAPSHOT/alluxio-underfs-swift-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.4.0-SNAPSHOT/alluxio-underfs-swift-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/pom.xml to org.alluxio/alluxio-underfs-s3a/1.4.0-SNAPSHOT/alluxio-underfs-s3a-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.4.0-SNAPSHOT/alluxio-examples-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.4.0-SNAPSHOT/alluxio-core-server-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.4.0-SNAPSHOT/alluxio-keyvalue-common-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.4.0-SNAPSHOT/alluxio-underfs-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.4.0-SNAPSHOT/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.4.0-SNAPSHOT/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.4.0-SNAPSHOT/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.4.0-SNAPSHOT/alluxio-integration-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.4.0-SNAPSHOT/alluxio-keyvalue-1.4.0-SNAPSHOT.pomchannel stopped
Test FAILed.

harshavardhana · 2016-10-23T08:05:33Z

Build failure fixed.

AmplabJenkins · 2016-10-23T08:11:08Z

Merged build finished. Test PASSed.

AmplabJenkins · 2016-10-23T08:11:09Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12015/
Test PASSed.

calvinjia · 2016-10-26T20:37:17Z

core/common/src/main/java/alluxio/PropertyKey.java

@@ -411,7 +414,8 @@
        "alluxio.underfs.s3.admin.threads.max";
    public static final String UNDERFS_S3_DISABLE_DNS_BUCKETS =
        "alluxio.underfs.s3.disable.dns.buckets";
-    public static final String UNDERFS_S3_ENDPOINT = "alluxio.underfs.s3.endpoint";
+    public static final String UNDERFS_S3_ENDPOINT =
+        "alluxio.underfs.s3.endpoint";


Could you revert the formatting change here?

calvinjia · 2016-10-26T20:37:31Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

+      if (Configuration.get(PropertyKey.UNDERFS_S3_DISABLE_DNS_BUCKETS).equals("true")) {
+        S3ClientOptions clientOptions = new S3ClientOptions();
+        clientOptions.withPathStyleAccess(true);
+        amazonS3Client.setS3ClientOptions(clientOptions);


I think the recommended way is to use the Builder pattern.

calvinjia · 2016-10-26T20:38:04Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

+    if (Configuration.containsKey(PropertyKey.UNDERFS_S3_DISABLE_DNS_BUCKETS)) {
+      // Disable DNS style buckets, this enables path style primary useful for
+      // s3 compliant endpoints.
+      if (Configuration.get(PropertyKey.UNDERFS_S3_DISABLE_DNS_BUCKETS).equals("true")) {


Could use Configuration.getBoolean here

calvinjia · 2016-10-26T20:38:19Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

+    String accountOwner = ""; // There is no known account owner by default.
+    // if ACL enabled inherit bucket acl for all the objects.
+    if (Configuration.containsKey(PropertyKey.UNDERFS_S3A_ENABLE_ACL)) {
+      if (Configuration.get(PropertyKey.UNDERFS_S3A_ENABLE_ACL).equals("true")) {


Could use Configuration.getBoolean here

calvinjia · 2016-10-26T20:43:43Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

    if (Configuration.containsKey(PropertyKey.UNDERFS_S3_ENDPOINT)) {
      amazonS3Client.setEndpoint(Configuration.get(PropertyKey.UNDERFS_S3_ENDPOINT));
    }
+    if (Configuration.containsKey(PropertyKey.UNDERFS_S3_DISABLE_DNS_BUCKETS)) {


Since you have already set a default value for the key, its unnecessary to check the existence.

calvinjia · 2016-10-26T20:43:55Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

+    short bucketMode = (short) 700;
+    String accountOwner = ""; // There is no known account owner by default.
+    // if ACL enabled inherit bucket acl for all the objects.
+    if (Configuration.containsKey(PropertyKey.UNDERFS_S3A_ENABLE_ACL)) {


Since you have already set a default value for the key, its unnecessary to check the existence.

AmplabJenkins · 2016-10-26T23:29:22Z

Merged build finished. Test PASSed.

AmplabJenkins · 2016-10-26T23:29:22Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12085/
Test PASSed.

calvinjia · 2016-10-26T23:32:41Z

core/common/src/main/java/alluxio/PropertyKey.java

@@ -398,6 +399,7 @@
        "alluxio.underfs.oss.connection.timeout.ms";
    public static final String UNDERFS_OSS_CONNECT_TTL = "alluxio.underfs.oss.connection.ttl";
    public static final String UNDERFS_OSS_SOCKET_TIMEOUT = "alluxio.underfs.oss.socket.timeout.ms";
+    public static final String UNDERFS_S3A_ENABLE_ACL = "alluxio.underfs.s3a.enable.acl";


Could you document this new configuration option? Also, this may be better named like inherit_acl.

Where would you document this?

calvinjia · 2016-10-26T23:34:14Z

underfs/s3a/src/main/java/alluxio/underfs/s3a/S3AUnderFileSystem.java

    if (Configuration.containsKey(PropertyKey.UNDERFS_S3_ENDPOINT)) {
      amazonS3Client.setEndpoint(Configuration.get(PropertyKey.UNDERFS_S3_ENDPOINT));
    }
+    // Disable DNS style buckets, this enables path style requests.
+    if (Configuration.getBoolean(PropertyKey.UNDERFS_S3_DISABLE_DNS_BUCKETS)) {


Could you set the default value of this property in PropertyKey to be false?

sure. I think @gpang asked me to keep it as "null"

I think he was referring to the new region field you added. Since all users of this property (s3n/s3a) default to false when it is empty, we should be able to use a default value.

calvinjia · 2016-10-26T23:34:52Z

@harshavardhana Two minor comments otherwise this looks good.

AmplabJenkins · 2016-10-27T00:35:53Z

Merged build finished. Test PASSed.

AmplabJenkins · 2016-10-27T00:35:54Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12088/
Test PASSed.

harshavardhana · 2016-10-27T00:47:54Z

Done documented. Let me know the wording @calvinjia

AmplabJenkins · 2016-10-27T01:07:18Z

Merged build finished. Test FAILed.

AmplabJenkins · 2016-10-27T01:07:19Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12089/

Failed Tests: 1

org.alluxio:alluxio-tests: 1

alluxio.master.file.FileSystemMasterIntegrationTest.concurrentCreate

Test FAILed.

harshavardhana · 2016-10-27T01:40:41Z

Is this related to my patch?

java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: alluxio.exception.FileDoesNotExistException: inodeId 16458448895 does not exist
    at alluxio.master.file.meta.InodeTree.lockFullInodePath(InodeTree.java:354)
    at alluxio.master.file.FileSystemMaster.getFileInfo(FileSystemMaster.java:465)
    at alluxio.master.file.FileSystemMasterIntegrationTest$ConcurrentCreator.exec(FileSystemMasterIntegrationTest.java:687)
    at alluxio.master.file.FileSystemMasterIntegrationTest$ConcurrentCreator.exec(FileSystemMasterIntegrationTest.java:717)
    at alluxio.master.file.FileSystemMasterIntegrationTest$ConcurrentCreator.exec(FileSystemMasterIntegrationTest.java:717)
    at alluxio.master.file.FileSystemMasterIntegrationTest$ConcurrentCreator.call(FileSystemMasterIntegrationTest.java:676)
    at alluxio.master.file.FileSystemMasterIntegrationTest$ConcurrentCreator.call(FileSystemMasterIntegrationTest.java:662)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)

harshavardhana · 2016-10-27T01:40:58Z

Jenkins, test this please.

gpang · 2016-10-27T15:44:14Z

Jenkins, test this please

AmplabJenkins · 2016-10-27T16:09:46Z

Merged build finished. Test PASSed.

AmplabJenkins · 2016-10-27T16:09:46Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12095/
Test PASSed.

calvinjia · 2016-10-27T18:22:25Z

LGTM

harshavardhana · 2016-10-28T18:10:52Z

Is there anything else pending on us for this patch @gpang @calvinjia ?

calvinjia · 2016-10-28T18:13:35Z

docs/_data/table/common-configuration.csv

 alluxio.underfs.s3a.consistency.timeout.ms,60000
 alluxio.underfs.s3a.direct.writes.enabled,true
 alluxio.underfs.s3a.secure.http.enabled,false
 alluxio.underfs.s3a.server.side.encryption.enabled,false
 alluxio.underfs.s3a.socket.timeout.ms,50000
+alluxio.underfs.s3a.enable.acl,true


Could you update this value to match the new one?

Ah sorry, doing that right away.

This patch brings in two new options to `alluxio-site.properties` - UNDERFS_S3A_ENABLE_ACL to disable inheriting bucket ACLs This patch also adds support for s3a driver to honor disabling `dns.buckets` A sample configuration looks like this Fixes https://alluxio.atlassian.net/browse/ALLUXIO-2397 ``` alluxio.underfs.address=s3a://testbucket/ alluxio.underfs.s3.disable.dns.buckets=true alluxio.underfs.s3.endpoint=http://localhost:9000 alluxio.underfs.s3a.region="us-east-1" alluxio.underfs.s3a.enable.acl=false aws.accessKeyId=USWUXHGYZQYFYFFIT3RE aws.secretKey=MOJRH0mkL1IPauahWITSVvyDrQbEEIwljvmxdq03 ```

harshavardhana · 2016-10-28T18:37:28Z

Done @calvinjia

AmplabJenkins · 2016-10-28T18:56:05Z

Merged build finished. Test PASSed.

AmplabJenkins · 2016-10-28T18:56:06Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12118/
Test PASSed.

gpang

LGTM

alluxio-bot added the cla-missing label Oct 22, 2016

alluxio-bot removed the cla-missing label Oct 22, 2016

harshavardhana changed the title ~~Add support for alluxio with Minio.~~ [ALLUXIO-2397] Add support for alluxio with Minio. Oct 22, 2016

harshavardhana force-pushed the alluxio-minio branch from 40f32c0 to fe9e063 Compare October 22, 2016 00:26

harshavardhana force-pushed the alluxio-minio branch from fe9e063 to b16239c Compare October 22, 2016 00:27

harshavardhana mentioned this pull request Oct 22, 2016

Evaluate aluxio integration with Minio server minio/minio#2981

Closed

gpang suggested changes Oct 23, 2016

View reviewed changes

harshavardhana force-pushed the alluxio-minio branch from b16239c to cfb6bd7 Compare October 23, 2016 06:51

harshavardhana force-pushed the alluxio-minio branch from cfb6bd7 to 6115e4a Compare October 23, 2016 07:32

calvinjia requested changes Oct 26, 2016

View reviewed changes

calvinjia reviewed Oct 26, 2016

View reviewed changes

harshavardhana force-pushed the alluxio-minio branch from 77f074d to 2850248 Compare October 27, 2016 00:16

harshavardhana force-pushed the alluxio-minio branch from 2850248 to c749734 Compare October 27, 2016 00:47

calvinjia approved these changes Oct 27, 2016

View reviewed changes

calvinjia reviewed Oct 28, 2016

View reviewed changes

harshavardhana force-pushed the alluxio-minio branch from c749734 to d4948ef Compare October 28, 2016 18:37

gpang approved these changes Oct 28, 2016

View reviewed changes

gpang merged commit f5a6eb3 into Alluxio:master Oct 28, 2016

harshavardhana deleted the alluxio-minio branch October 28, 2016 20:05

nitisht mentioned this pull request Jan 10, 2017

[awesome-tool]: Add Alluxio to awesome Minio minio/awesome-minio#38

Closed

[ALLUXIO-2397] Add support for alluxio with Minio. #4217

[ALLUXIO-2397] Add support for alluxio with Minio. #4217

Conversation

harshavardhana commented Oct 22, 2016 • edited

alluxio-bot commented Oct 22, 2016

alluxio-bot commented Oct 22, 2016

AmplabJenkins commented Oct 22, 2016

alluxio-bot commented Oct 22, 2016

alluxio-bot commented Oct 22, 2016

alluxio-bot commented Oct 22, 2016

harshavardhana commented Oct 22, 2016

alluxio-bot commented Oct 22, 2016

harshavardhana commented Oct 22, 2016

aaudiber commented Oct 22, 2016

aaudiber commented Oct 22, 2016

AmplabJenkins commented Oct 22, 2016

AmplabJenkins commented Oct 22, 2016

alluxio-bot commented Oct 22, 2016

gpang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harshavardhana commented Oct 23, 2016 • edited

AmplabJenkins commented Oct 23, 2016

AmplabJenkins commented Oct 23, 2016

Build result: FAILURE

harshavardhana commented Oct 23, 2016

AmplabJenkins commented Oct 23, 2016

AmplabJenkins commented Oct 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmplabJenkins commented Oct 26, 2016

AmplabJenkins commented Oct 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calvinjia commented Oct 26, 2016

AmplabJenkins commented Oct 27, 2016

AmplabJenkins commented Oct 27, 2016

harshavardhana commented Oct 27, 2016

AmplabJenkins commented Oct 27, 2016

AmplabJenkins commented Oct 27, 2016

Failed Tests: 1

org.alluxio:alluxio-tests: 1

harshavardhana commented Oct 27, 2016

harshavardhana commented Oct 27, 2016

gpang commented Oct 27, 2016

AmplabJenkins commented Oct 27, 2016

AmplabJenkins commented Oct 27, 2016

calvinjia commented Oct 27, 2016

harshavardhana commented Oct 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harshavardhana commented Oct 28, 2016

AmplabJenkins commented Oct 28, 2016

AmplabJenkins commented Oct 28, 2016

gpang left a comment

Choose a reason for hiding this comment

harshavardhana commented Oct 22, 2016 •

edited

harshavardhana commented Oct 23, 2016 •

edited