Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to structure project #28

Closed
rhlsthrm opened this issue Jun 4, 2017 · 5 comments
Closed

Figure out how to structure project #28

rhlsthrm opened this issue Jun 4, 2017 · 5 comments

Comments

@rhlsthrm
Copy link
Collaborator

rhlsthrm commented Jun 4, 2017

I think we should nest components by functionality and how they will be used, similar to what this article describes: https://medium.com/@alexmngn/how-to-better-organize-your-react-applications-2fd3ea1920f1

We can have top level components and nest components within our "scenes". What do you guys think?

@rhlsthrm
Copy link
Collaborator Author

rhlsthrm commented Jun 4, 2017

My latest PR has a first-pass implementation of this structure.

@imbaniac
Copy link
Collaborator

imbaniac commented Jun 4, 2017

It's a good idea for enterprise apps with a ton of components, but for us, it'll be overcomplication.
We just don't need to have standalone modules and creating own actions, reducers, and components in each folder will be crazy.
Let's follow regular:

  • actions
  • components
  • containers
  • reducers
  • utils

Still, we can borrow some ideas from the architecture

@rhlsthrm
Copy link
Collaborator Author

rhlsthrm commented Jun 4, 2017

So far I've found it easier working this way but if you guys are used to the traditional methods I'm fine with that.

@imbaniac
Copy link
Collaborator

imbaniac commented Jun 4, 2017

It's easier while we haven't added redux. This post describes a few bad practices and very complicated nested structure.

@rhlsthrm
Copy link
Collaborator Author

rhlsthrm commented Jun 4, 2017 via email

@rhlsthrm rhlsthrm closed this as completed Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants