-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native brotli when available and make iltorb & node-zopfli-es optional #36
Use native brotli when available and make iltorb & node-zopfli-es optional #36
Conversation
Hey, thanks for the PR. Looks good overall, just a couple of minor things. The Readme should also be updated with updated install instructions as the package now has peer dependencies. CI is failing because Node 12 was just released and the native bindings haven't been updated for the new API version - that's fine and temporary. |
Thanks for your prompt response, @Alorel ! I've switched to |
Great, thanks 🙂 I can't make edits to a forked project, so as soon as you resolve conflicts with master it'll be good to merge (it should only be a |
@Alorel I resolved the package.json conflicts last night and GitHub say there are no conflicts. Am I missing something? |
Hm, it's showing up as conflicting on github.com, but mergeable on the FastHub app |
Published as v4.0.0 - thanks again for the contribution! |
First off, thank you for maintaining this fork. Really appreciated.
Purpose
Make
shrink-ray
more fault-tolerant, so it can install and run without fatal errors on more versions of Node and build environments.Ingredients
iltorb
andnode-zopfli-es
to peer dependencies, so consuming apps can control their exact versions.iltorb
when not. When neither are available, fall back to gzip.node-zopfli-es
when available, and fall back to gzip when not.node-zopfli-es
andmocha
to comply with security audits.proxyquire
utility to simulate when modules are unavailable.Compatibility
Tested locally on Node:
v8.10.0
v8.12.0
v10.14.2
v11.14.0