Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidates issue with oh-my-zsh #43

Closed
seagle0128 opened this issue Feb 26, 2020 · 6 comments
Closed

Candidates issue with oh-my-zsh #43

seagle0128 opened this issue Feb 26, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@seagle0128
Copy link

Hi, Thanks for the great zsh plugin! I really like it.

But I have an minor issue with oh-my-zsh. As you know, oh-my-zsh also provides completion mechanism. The screenshot is below.

image

If enabling fzf-tab, it looks like this. The group headers are listed in the candidates as well. Can they be removed for better experience? It's better to colorize the candidates for different groups IMO.

image

@romkatv
Copy link
Contributor

romkatv commented Feb 26, 2020

See #24.

fzf-tab is not supposed or guaranteed to work perfectly with any set of completion styles. It's natural and even expected that if you take an existing set of completion styles optimized for some other UI and drop fzf-tab on it, it'll look suboptimal.

P.S.

oh-my-zsh doesn't provide completion mechanism. It just sets a few parameters that Zsh provides. That is Zsh allows you to choose whether to display menu on the first tab or the second, how to display groups, etc. Oh My Zsh simply makes some arbitrary choices.

@seagle0128
Copy link
Author

Okay. Thanks for your quick reply. I am closing it.

@romkatv
Copy link
Contributor

romkatv commented Feb 26, 2020

I should have mentioned I'm just another user of fzf-tab (will always do so in the future when commenting here). The owner of the project is the one in charge here.

@seagle0128 seagle0128 reopened this Feb 26, 2020
@seagle0128
Copy link
Author

seagle0128 commented Feb 26, 2020

Sorry! I reopen this issue since I found this similar plugin is able to handle the group names correctly. Bu it has less features obviously.

@romkatv Thanks anyway!

@seagle0128
Copy link
Author

seagle0128 commented Feb 26, 2020

Aha, I got a workaround and it works well in my env.

Updated: Use export FZF_TAB_SHOW_GROUP=brief to hide the group names.

image

seagle0128 added a commit to seagle0128/dotfiles that referenced this issue Feb 26, 2020
@Aloxaf
Copy link
Owner

Aloxaf commented Feb 27, 2020

Sorry I am late here. As @romkatv(thank you so much) says this is an known issue.

But you don't need to hide the headers, you can overwrite the zsh's default settings, eg zstyle ':completion:*:descriptions' format '-- %d --'.

@Aloxaf Aloxaf added the bug Something isn't working label Feb 27, 2020
@Aloxaf Aloxaf closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants