Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/various issues #146

Merged
merged 13 commits into from
Sep 9, 2018
Merged

Fix/various issues #146

merged 13 commits into from
Sep 9, 2018

Conversation

mclarsen
Copy link
Member

@mclarsen mclarsen commented Sep 8, 2018

No description provided.

This was referenced Sep 8, 2018
@cyrush
Copy link
Member

cyrush commented Sep 8, 2018

@mclarsen hola is hanging b/c mesh bp verify is failing on at least one of the ranks, causing that MPI task to crash and the others to wait for eternity

@cyrush
Copy link
Member

cyrush commented Sep 8, 2018

i understand the hola issue, my spack changes made conduit 0.3.1 build again, instead of conduit@master

@mclarsen
Copy link
Member Author

mclarsen commented Sep 8, 2018

@cyrush I had to resolve the undefined symbol to register filter that occurring when vtkh was off and python wanted to see register_filter. Instead of a quick fix, I am going to compile the ascent runtime without vtkh. To support this the right way, I will need to change some of the tests to look at a new about variable that indicates if vtkh is enabled.

@cyrush
Copy link
Member

cyrush commented Sep 8, 2018

looks like its still picking up wrong conduit for the main case, perhaps it has to do with +mfem

@cyrush
Copy link
Member

cyrush commented Sep 8, 2018

mfem requires conduit version 0.3.1:, but spec asked for master,

I thought the mfem constraint was 0.3.1 or greater, but obviously something is wrong -- I'll try to fix this soon.

@mclarsen
Copy link
Member Author

mclarsen commented Sep 8, 2018 via email

@cyrush
Copy link
Member

cyrush commented Sep 9, 2018 via email

@mclarsen
Copy link
Member Author

mclarsen commented Sep 9, 2018

@cyrush Do the ascent runtime changes look ok to you?

@mclarsen
Copy link
Member Author

mclarsen commented Sep 9, 2018

This allows us to test extracts without having to compile in vtkm or vtkh

@cyrush
Copy link
Member

cyrush commented Sep 9, 2018

glanced at the changes -- looks good to me!

@mclarsen
Copy link
Member Author

mclarsen commented Sep 9, 2018

OK. We be green again.

@mclarsen mclarsen closed this Sep 9, 2018
@mclarsen mclarsen reopened this Sep 9, 2018
@cyrush
Copy link
Member

cyrush commented Sep 9, 2018

Nice, thanks for tackling all of those issues!

@cyrush cyrush deleted the fix/various_issues branch November 1, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants