Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added shell/bundle_all_test.sh #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

UnixJunkie
Copy link
Contributor

I hope each execution of opam-bundle is independant, so that we can run many in parallel.

@UnixJunkie
Copy link
Contributor Author

related to #8

@AltGr
Copy link
Owner

AltGr commented Dec 3, 2018

This seems useful! The real test would be to try and actually install the generated bundles though :)
One thing: the shell/ directory is at the moment used to contain the scripts that are included in the bundle and part of the binary itself. Maybe it should be renamed to shell_src/ or something like that, but I don't think test scripts should be in the same directory.

@UnixJunkie
Copy link
Contributor Author

I renamed the file to scripts/bundle_all_test.sh.

@UnixJunkie
Copy link
Contributor Author

To install all of them, I should setup some VM obviously.
It is annoying that so many packages have "No solution".

@AltGr
Copy link
Owner

AltGr commented Dec 4, 2018

Thanks!

It is annoying that so many packages have "No solution".

It's just because the OCaml version is fixed at bundle creation time, I think. Opam has a feature to automatically select a compatible compiler (used when you do opam switch create ., for example), but opam-bundle can't easily use that at the moment. So what happens in the script is that the OCaml version is fixed to the default¹, and any packages that require a different version end up with "No solution". This is also bad because some packages could end up bundled with an older version because of an older compiler.

Ah, also, just noticed, you should use opam list -s rather than opam search | awk '!/^#/{print $1}'.

¹ the default is to use the currently installed OCaml version (at bundle creation time), and failing that, 4.04.1

@UnixJunkie
Copy link
Contributor Author

Ok, I didn't know about opam list {--short|-s}.
I use it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants