Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : empty environment bug #31

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix : empty environment bug #31

merged 1 commit into from
May 4, 2023

Conversation

hernoufM
Copy link
Contributor

@hernoufM hernoufM commented May 3, 2023

This PR fixes tool's behavior with regard to environment to match what it describes in manual :

--environment[=VAL] (default=)
     ...
     If set without argument, an empty environment used: this can be 
     used to ensure the generated bundle won't have arch or OS constraints.

Before that, the empty environment was perceived literally as a filter that filtered out all packages that had at least some availability constraints.

Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny changes, otherwise lgtm!

src/opamBundleMain.ml Show resolved Hide resolved
src/opamBundleMain.ml Outdated Show resolved Hide resolved
@rjbou rjbou merged commit e45a1e8 into AltGr:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants