Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull docker images reporting #311

Open
tarnas14 opened this issue Jun 23, 2022 · 0 comments
Open

Pull docker images reporting #311

tarnas14 opened this issue Jun 23, 2022 · 0 comments
Assignees
Labels

Comments

@tarnas14
Copy link

tarnas14 commented Jun 23, 2022

refactor backend docker image management

AC:

  1. extend image_list to include information if there is a newer version available on docker hub
    image
  2. expose a tauri command to pull a specific image instead of all images
  3. expose an event stream of image pull operations, tari://pull_image_progress, (both pull_image and pull_images) , which would push events like
{
  dockerImage: "<image_name>", // full name of docker image so we can assign state to it
  status: "pulling", // DockerImagePullStatus
  progress: 20, // progress in %
  error: "error message or null" // if there is an error message, we show it to the user
}

enum DockerImagePullStatus {
  Waiting = 'waiting',
  Pulling = 'pulling',
  Ready = 'ready',
}

NOTE: right now an event stream of verbatim docker strings is pushed, we can either leave it like this and show to the user or parse and stream that
4. the above commands need to accept dockerRegistry and dockerTag as parameters, as it is configurable on launchpad


statuses (up_to_date, waiting, fs_layer, pulling)
image

@tarnas14 tarnas14 added this to the #4 FinishOnboarding milestone Jun 23, 2022
@tarnas14 tarnas14 assigned tarnas14 and alex1307 and unassigned tarnas14 Jun 23, 2022
alex1307 added a commit that referenced this issue Jun 27, 2022
Description
Feature: #311

We should provide meta information about the docker images.
If images are not up to date(latest) then we should pull and start the latest ones.

Motivation and Context

User should be able to upgrade to the latest image or to start a custom image.

How Has This Been Tested?
This is not tested as it is in progress.
CjS77 pushed a commit that referenced this issue Jun 30, 2022
* feat: pull docker images reporting

Description
Feature: #311

We should provide meta information about the docker images.
If images are not up to date(latest) then we should pull and start the latest ones.

Motivation and Context

User should be able to upgrade to the latest image or to start a custom image.

How Has This Been Tested?
This is not tested as it is in progress.

* Alligning image info model with the front-end
alex1307 added a commit that referenced this issue Jul 8, 2022
Description

We should provide info whether the current docker images are up to date.
We should show `docker pull image` to the user.

Motivation and Context
feature #311

How Has This Been Tested?
Manually tested. All tests were run locally successfully.
All tests are ignored as they expect Docker engine running.
Latest docker images are downloaded.
CjS77 pushed a commit that referenced this issue Jul 11, 2022
* fix: download latest docker image
Description

We should provide info whether the current docker images are up to date.
We should show `docker pull image` to the user.

Motivation and Context
feature #311

How Has This Been Tested?
Manually tested. All tests were run locally successfully.
All tests are ignored as they expect Docker engine running.
Latest docker images are downloaded.

* cargo fmt --all

* fixing lints clippy checks

* cargo fmt --all

* fixing lints clippy checks

* Fixing PR comments and improving the code quality

* cargo fmt --all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants