feat: pull docker images reporting #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description Feature: #311 We should provide meta information about the docker images. If images are not up to date(latest) then we should pull and start the latest ones. Motivation and Context User should be able to upgrade to the latest image or to start a custom image. How Has This Been Tested? This is not tested as it is in progress.
tarnas14
reviewed
Jun 29, 2022
| @@ -53,6 +53,9 @@ pub struct ImageInfo { | |||
| image_name: String, | |||
| display_name: String, | |||
| docker_image: String, | |||
| is_updated: bool, | |||
There was a problem hiding this comment.
Suggested change
| is_updated: bool, | |
| latest: bool, |
on frontend we assumed
// gui-react/src/types/general.ts:46
export type DockerImage = {
imageName: string
displayName: string
dockerImage: string
latest: boolean
pending?: boolean
error?: string
progress?: number
status?: DockerImagePullStatus
}
export enum DockerImagePullStatus {
Waiting = 'waiting',
Pulling = 'pulling',
Ready = 'ready',
}There was a problem hiding this comment.
The changes are implemented.
CjS77
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature: #311
We should provide meta information about the docker images.
If images are not up to date(latest) then we should pull and start the latest ones.
Motivation and Context
User should be able to upgrade to the latest image or to start a custom image.
How Has This Been Tested?
This is not tested as it is in progress.