feat: query result sharing #904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdiGajbhiye
requested review from
suryaiyer95,
mdesmet and
saravmajestic
and removed request for
suryaiyer95
| .get<string>("altimateInstanceName"); | ||
| if (!company) { | ||
| window.showErrorMessage( | ||
| "Please instance name and API key for inviting user.", |
There was a problem hiding this comment.
Suggested change
| "Please instance name and API key for inviting user.", | |
| "Please add instance name and API key for inviting user.", |
There was a problem hiding this comment.
why dont you use handlePreviewFeatures check instead of checking just instance name?
AdiGajbhiye
force-pushed
the
feat/query-result-sharing
branch
3 times, most recently
from
f8bba39
to
53c1845
Compare
feat: change endpoint feat: added button WIP WIP WIP WIP feat: added checks WIP fix: styling WIP feat: added invite user feat: added feature flag in settings WIP feat: added progress bars fix: styling WIP WIP fix: added greyed out share button feat: add tooltip WIP WIP WIP WIP WIP fix: text fix: error message fix: model path fix: disable admin role fix: as per comments fix: text fix: make url a linik feat: added project name
AdiGajbhiye
force-pushed
the
feat/query-result-sharing
branch
from
53c1845
to
67ce2e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist
README.mdupdated and added information about my change