-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added SharedReplacingMergeTree support #582
Conversation
Hi @vpol , thanks for your contribution, we have added it to |
Hi. Thank you for reply. After some quick research I discovered that SharedMergeTree (and SharedReplacingMergeTree) is only available in clickhouse.cloud, not sure how I can write tests in this case. From: https://clickhouse.com/docs/en/cloud/reference/shared-merge-tree
From what I understand it works exactly the same way as ReplicatedReplacingMergeTree, and was not supported purely because it has a different name and is not present in enum's. |
Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
@vpol out of curiosity, I thought ClickHouse cloud would automatically turn the MergeTree tables of any kind into their Shared version. |
it does, but it looks like it's turning it into a different "proprietary" table engine, with different name. name that is not correctly handled by the current code. |
Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
Tables created by clickhouse.cloud have SharedReplacingMergeTree engine, which currently is not handled correctly.