Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare authorization for system user #479

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Prepare authorization for system user #479

merged 4 commits into from
Jun 24, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Jun 24, 2024 •
edited
Loading

Description

Various changes in auth layer.

  • Remove UserId parameter from auth call. The system user id will be retrieved from claims by Altinn.ABAC library (when it is updated).
  • Updated events integration to strip the organization number 0192: prefix when setting events subject as it is not expected there.
  • Updated BasePolicy.xml

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron marked this pull request as ready for review June 24, 2024 09:25
Andreass2
Andreass2 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ceredron Ceredron merged commit 8181159 into main Jun 24, 2024
5 checks passed
@Ceredron Ceredron deleted the feat/system-user branch June 24, 2024 09:56
@Ceredron Ceredron linked an issue Jun 25, 2024 that may be closed by this pull request
Teste autorisasjon av Broker Events etter endring utført i Altinn Events #408
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreass2 Andreass2 Andreass2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teste autorisasjon av Broker Events etter endring utført i Altinn Events
2 participants
@Ceredron @Andreass2