Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13060 replace legacy components with new ones from design system #13129

Merged
merged 62 commits into from
Jul 29, 2024
Merged

13060 replace legacy components with new ones from design system #13129

merged 62 commits into from
Jul 29, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Jul 10, 2024 •
edited
Loading

Description

Tasks
Beta Give feedback

Dependency on @digdir/design-system-react is also removed as the newer components use @digdir/designsystemet-react

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Jondyr Jondyr linked an issue Jul 10, 2024 that may be closed by this pull request
Replace Legacy components with new ones from design system #13060
Closed
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. area/text-editor labels Jul 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.02174% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.87%. Comparing base (957f66f) to head (ff7f5bf).
Report is 2 commits behind head on main.

Files Patch % Lines
...rictions/NumberRestrictions/NumberRestrictions.tsx 40.00% 0 Missing and 3 partials ⚠️
...ssionEditMode/SimpleExpression/DataSourceValue.tsx 75.00% 2 Missing ⚠️
...c/components/SchemaInspector/ItemDataComponent.tsx 66.66% 1 Missing ⚠️
...onents/GiteaHeader/ThreeDotsMenu/ThreeDotsMenu.tsx 66.66% 1 Missing ⚠️
...sionEditMode/SimpleExpression/SimpleExpression.tsx 85.71% 0 Missing and 1 partial ⚠️
...EditMode/SimpleExpression/SubExpressionContent.tsx 88.88% 1 Missing ⚠️
...3/src/components/config/editModal/EditCodeList.tsx 80.00% 1 Missing ⚠️
...nfig/componentSpecificContent/Map/MapComponent.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13129      +/-   ##
==========================================
+ Coverage   92.86%   92.87%   +0.01%     
==========================================
  Files        1442     1442              
  Lines       20174    20181       +7     
  Branches     2423     2427       +4     
==========================================
+ Hits        18734    18743       +9     
- Misses       1178     1183       +5     
+ Partials      262      255       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr force-pushed the 13060-replace-legacy-components-with-new-ones-from-design-system branch 3 times, most recently from 0b96bb2 to 524094f Compare July 16, 2024 07:43
Jondyr added 20 commits July 17, 2024 14:36
@Jondyr
Change AppPreviewBar LegacySelect to StudioNativeSelect
7b9ba18
@Jondyr
Change SecurityLevelSelect LegacySelect to StudioNativeSelect
d525df2
@Jondyr
Change LangSelector LegacySelect to StudioNativeSelect
7c5313c
@Jondyr
Remove selected property from <option>
4268793
@Jondyr
Change SchemaInspector LegacySelect to StudioNativeSelect
18b9f7f
@Jondyr
Change PolicyCardRules LegacySelect to StudioNativeSelect
753ae63
@Jondyr
Use defaultValue instead of selected on <option>
a04661c
@Jondyr
Change TextResourceEditor LegacySelect to StudioNativeSelect
9b4b039
@Jondyr
Change componentSpecificContent LegacySelect to StudioNativeSelect
2379830
@Jondyr
Delete unused code
de257f1
@Jondyr
Change componentconfig LegacySelect to StudioNativeSelect
c3d33a9 
Remove unused import
@Jondyr
Fix some tests broken after LegacySelect->StudioNativeSelect swap
b2a5754 
Fix some tests broken after LegacySelect->StudioNativeSelect swap
@Jondyr
Fix failing each() tests
2c3179e
@Jondyr
Replace LegacyTextField with StudioTextfield in schemainspector
244bae0
@Jondyr
Fix css after replacing legacy components
9aac15a
@Jondyr
Replace LegacyTextField and fix possible bug with saving float numbers
b5e2ecc 
Bug: saving float numbers for min/max restrictions on number components
@Jondyr
Fix formatting
4742445
@Jondyr
Replace LegacyTextField for ux-editor, delete unused code
e8a03cf
@Jondyr
Fix tests after replacing LegacyTextField
28662f9
@Jondyr
Fix interesting test failure, new component allows exponents like 1e2
23069d0 
"1test 2" becomes "1e2" = 1*10^2=100
@Jondyr Jondyr force-pushed the 13060-replace-legacy-components-with-new-ones-from-design-system branch from 96fd001 to fc31100 Compare July 22, 2024 13:32
@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. skip-releasenotes Issues that do not make sense to list in our release notes labels Jul 22, 2024
@Jondyr Jondyr force-pushed the 13060-replace-legacy-components-with-new-ones-from-design-system branch 2 times, most recently from fe21d5e to 7abdb05 Compare July 23, 2024 12:25
@Jondyr Jondyr marked this pull request as ready for review July 25, 2024 07:14
@Jondyr Jondyr force-pushed the 13060-replace-legacy-components-with-new-ones-from-design-system branch from 8a6c36e to 7255e8b Compare July 25, 2024 08:39
TomasEng
TomasEng reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@TomasEng TomasEng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Litt av en jobb! Har bare noen spørsmål, og et forslag som vil gjør at vi slipper å måtte sette id på StudioNativeSelect.

frontend/libs/studio-components/src/components/StudioNativeSelect/StudioNativeSelect.tsx Outdated Show resolved Hide resolved
...tend/packages/process-editor/src/components/ConfigPanel/ConfigContent/ConfigContent.test.tsx Show resolved Hide resolved
frontend/packages/text-editor/src/LangSelector.test.tsx Show resolved Hide resolved
frontend/packages/ux-editor/src/components/config/SelectDataFieldComponent.test.tsx Outdated Show resolved Hide resolved
@Jondyr Jondyr requested a review from TomasEng July 25, 2024 14:34
TomasEng
TomasEng approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfekt!

@Jondyr Jondyr merged commit acdd7bc into main Jul 29, 2024
9 checks passed
@Jondyr Jondyr deleted the 13060-replace-legacy-components-with-new-ones-from-design-system branch July 29, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasEng TomasEng TomasEng approved these changes

Assignees
No one assigned
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Legacy components with new ones from design system
5 participants
@Jondyr @TomasEng @JamalAlabdullah @ErlingHauan @mirkoSekulic