Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure each processed listener given isolated state #53

Closed
timkinnane opened this issue Jun 25, 2018 · 0 comments
Closed

Ensure each processed listener given isolated state #53

timkinnane opened this issue Jun 25, 2018 · 0 comments
Labels
BUG Something broke
Milestone
Alpha

Comments

@timkinnane
Copy link
Contributor

Test that states within subsequent listeners is isolated.
I think it's inheriting changes from the last processed listener.

See https://github.com/Amazebot/bbot/blob/master/src/lib/thought-process.spec.ts
@timkinnane timkinnane added the BUG Something broke label Jun 25, 2018
@timkinnane timkinnane added this to the Alpha milestone Jun 25, 2018
timkinnane added a commit that referenced this issue Aug 12, 2018
@timkinnane
fix(nlu): NLU matching fixes and other patches
ad3392b 
- Add `eq` operator for NLU score comparison
- Replaced old `eq` operator behaviour with `is`
- Don’t overwrite manually loaded middleware/adapters
- Remove dotenv from scripts, handled internally
- Update dependencies
- Add full typing for package json
- Make emoji data available to require
- Thought now uses copy of listeners (not reference)
- Fix state respond method
- Fix shell adapter double logging bug
- Fix shell adapter not rendering consecutive messages
- Fix NLU score matching operations
- Update Rocket.Chat demo with current usage
- Fix adapter path loading when sub-module
- Fix thought to understand if listeners forced
- Add regression tests for bugs found in production
- Closes #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Something broke
Projects
None yet
Milestone
Alpha
Development

No branches or pull requests
1 participant
@timkinnane