Event reducer test & sentryInterface response validation #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samparsky
force-pushed
the
event-aggregator-tests
branch
from
fd09ff8
to
de2a72f
Compare
samparsky
force-pushed
the
event-aggregator-tests
branch
from
de2a72f
to
c7b62aa
Compare
samparsky
changed the title
Ivshti
requested changes
Apr 29, 2019
| return fetchJson(url).then(({ validatorMessages }) => { | ||
| if (validatorMessages.length) { | ||
| const { err } = sentry.message.validate(validatorMessages) | ||
| return !err ? validatorMessages[0].msg : null |
There was a problem hiding this comment.
silent errors are not a good idea;
perhaps throw here and see what happens? I think it will be caught by the tick catch and the tick would be aborted, which is OK
Ivshti
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18 #32