Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider saving application state not only on application exit #222

Closed
ghost opened this issue Feb 17, 2023 · 1 comment
Closed

consider saving application state not only on application exit #222

ghost opened this issue Feb 17, 2023 · 1 comment
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Feb 17, 2023

Currently it seems that the application state is only saved when the application (cleanly) exists. Here are various scenarios where the application doesn't get cleanly closed, perhaps there are more:

  1. application crash;
  2. windows kills the application on shutdown/reboot because it doesn't respond fast enough to the "exit" signal;
  3. windows crash / spontaneous reboot

These are not necessarily the fault of the eduVPN app, there's a lot of subtly and less subtly broken Windows installations out there, but perhaps something (more) can be done to "keep state" in case these happen...

@rozmansi rozmansi self-assigned this Mar 16, 2023
@rozmansi rozmansi added this to the 3.4 milestone Mar 16, 2023
@rozmansi
Copy link
Member

Mind, that only settings that still do not trigger saving on the go are the window position and state (minimized, closed, etc.). Those settings are transferred from Windows to our settings collection on client close (or session end) and not on each client window move or resize. For performance reasons.

rozmansi added a commit that referenced this issue Apr 6, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue Apr 12, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue Apr 12, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue Apr 12, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue Apr 26, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue Apr 27, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue May 2, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue May 3, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue May 15, 2023
Reopens: #222, #173
Closes: #202
Signed-off-by: Simon Rozman <simon@rozman.si>
rozmansi added a commit that referenced this issue Jun 5, 2023
Fixes: #222
Signed-off-by: Simon Rozman <simon@rozman.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant