"Meta" milestone #53
Merged
"Meta" milestone #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest commits fixes #14 |
One was a duplicate, the other one was OS-related from Villages times
2 tasks
approxit
reviewed
May 1, 2018
showcase/src/test/copper.c
Outdated
|
|
||
| uwY += 2*bDir; | ||
|
|
||
| for(i = 0; i != 32; ++i) | ||
| for(i = 0; i != 32; ++i) { |
approxit
reviewed
May 1, 2018
| @@ -162,5 +171,5 @@ void timerWaitUs(UWORD uwUsCnt) { | |||
| // timerGetPrec(): One tick equals: PAL - 0.40us, NTSC - 0.45us | |||
| ULONG ulStart = timerGetPrec(); | |||
| UWORD uwTickCnt = uwUsCnt*2/5; | |||
| while(timerGetPrec() - ulStart < uwTickCnt); | |||
| while(timerGetPrec() - ulStart < uwTickCnt) {} | |||
There was a problem hiding this comment.
Good example for clangformat. Guess adding something to empty code blocks will show in diff, which we agreed to mitigate. Should be in new lines?
There was a problem hiding this comment.
I think that such change is significant enough to have it fully shown in diff. Also, the following code looks awful and doesn't look as done deliberately.
while(timerGetPrec() - ulStart < uwTickCnt) {
}
approxit
reviewed
May 1, 2018
| pManager->pCameraManager = cameraCreate(pVPort, 0, 0, uwBoundWidth, uwBoundHeight); | ||
| else | ||
| pManager->pCameraManager = (tCameraManager*)vPortGetManager(pVPort, VPM_CAMERA); | ||
| if(!pManager) { |
There was a problem hiding this comment.
Should it be pManager->pCameraManager?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43
fixes #14
fixes #48