Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rf 294: Remove Atomize Button #295

Merged
merged 9 commits into from
Jun 19, 2022
Merged

Rf 294: Remove Atomize Button #295

merged 9 commits into from
Jun 19, 2022

Conversation

Njima1572
Copy link
Collaborator

@Njima1572 Njima1572 commented May 31, 2022

Which Issue was this PR made for?

What is within the scope with this PR

  • Created Custom Button Component to replace atomize Button

Related Issue

Other sidenotes that reviewer should be aware of

Not the cleanest implementation. Would love to hear some suggestions.

Ended up implementing this because ref did not work on Atomize Button component

@Njima1572 Njima1572 requested review from siberowl and CaseRegan and removed request for siberowl May 31, 2022 19:35
@Njima1572 Njima1572 changed the title Rf 294 Rf 294: Remove Atomize Button May 31, 2022
@Njima1572 Njima1572 marked this pull request as ready for review May 31, 2022 20:53
@Njima1572 Njima1572 changed the base branch from main to rf-269 May 31, 2022 20:56
@Njima1572
Copy link
Collaborator Author

AUTOMATED: Deployed to https://pr-295.dev.mochatto.com

Copy link
Collaborator

@siberowl siberowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siberowl siberowl merged commit c7d2489 into rf-269 Jun 19, 2022
@siberowl siberowl deleted the rf-294 branch June 19, 2022 03:38
@siberowl siberowl restored the rf-294 branch October 22, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Join room on Enter key [Refactor] Get rid of atomzie-wrapper Button
2 participants