Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh network #30

Merged
merged 45 commits into from
Aug 7, 2021
Merged

Mesh network #30

merged 45 commits into from
Aug 7, 2021

Conversation

siberowl
Copy link
Collaborator

@siberowl siberowl commented Aug 4, 2021 •
edited by Njima1572
Loading

@siberowl
Copy link
Collaborator Author

siberowl commented Aug 4, 2021

Thinking about removing all WebRTC logic from RoomPage.tsx.

@Njima1572
Copy link
Collaborator

Thinking about removing all WebRTC logic from RoomPage.tsx.

Make it into a component or lib kind of removing??

@Njima1572 Njima1572 marked this pull request as ready for review August 4, 2021 17:53
@Njima1572 Njima1572 changed the base branch from main to voice-chat August 4, 2021 17:55
@siberowl siberowl marked this pull request as draft August 4, 2021 18:26
@Njima1572
Copy link
Collaborator

Server should hold the information of who is in the room already so that new user can get the list

Njima1572
Njima1572 requested changes Aug 4, 2021
View reviewed changes
client/src/RTCPeerConnector.ts Outdated Show resolved Hide resolved
client/src/RTCPeerConnector.ts Outdated Show resolved Hide resolved
client/src/RTCPeerConnector.ts Outdated Show resolved Hide resolved
@siberowl
Copy link
Collaborator Author

siberowl commented Aug 5, 2021

Calling initialization functions for the WebRTC network in RoomPage.tsx now. Still untested
https://github.com/Njima1572/spatialchatclone/blob/c7e9a070c6e142b5d23de45ddd76ebab00580ef9/client/src/pages/RoomPage.tsx#L11-L33

Base automatically changed from voice-chat to main August 6, 2021 17:35
@siberowl siberowl marked this pull request as ready for review August 7, 2021 10:09
@siberowl
Copy link
Collaborator Author

siberowl commented Aug 7, 2021

There are still some bugs that need to be identified and fixed (to be addressed using cypress in #35 ), but the basic voice chatting flow between multiple users works.

@siberowl siberowl merged commit 6c8d997 into main Aug 7, 2021
@siberowl siberowl deleted the mesh-network branch August 7, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Njima1572 Njima1572 Njima1572 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine join and chat pages into one url Support multiple WebRTC connections
2 participants
@siberowl @Njima1572