Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #27

Closed
wants to merge 1 commit into from
Closed

Conversation

akatsukilevi
Copy link
Contributor

Change due to security failure(Changed Hoek version from 4.2.0 to 5.0.3)

Change due to security failure(Changed Hoek version from 4.2.0 to 5.0.3)
@felixfong227
Copy link
Member

YAY @akatsukilevi thanks


Note 👇
Details about the vulnerabilitie

@moelrobi
Copy link
Member

But this could resolve into a major depenency error when there were major changes that other depenencies aren't prepered for.

@felixfong227
Copy link
Member

Well, if that's the case, we can always not upgraded the dependency that costing problems

@akatsukilevi
Copy link
Contributor Author

According to the Travis, it's passing, and if the package upgrades is a problem, we can freeze the version here so

@moelrobi
Copy link
Member

moelrobi commented Apr 30, 2018 via email

@moelrobi moelrobi added bug Something isn't working Security Everything relating to the Security for the Libary labels May 3, 2018
@felixfong227
Copy link
Member

The resolving patch has been moved to the following commit at the other branch
👇
2424e3c

Thanks @akatsukilevi 😉

@moelrobi moelrobi deleted the akatsukilevi-patch-1 branch May 13, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Security Everything relating to the Security for the Libary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants