Gpu multi thread #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amjad50
force-pushed
the
gpu_multi_thread
branch
from
f7299fb
to
45f9707
Compare
This is just moving the previous implementation to another thread, there is no improvement, so its still slow. There is also a stupid case with `gpu_read`, I added a delay when reading from the channel, since sometimes, the backend isn't fast enough to send the whole thing faster than the dma.
This design now, will try to use the same buffer until any of the following happens: - front_blit - drawing textured/transparent polygon/line - read command Because these require last state of the vram, the front_blit and reading is ok, but would be nice to optimize for textured and transparent drawing. This design now, makes emulation faster for drawing many opaque polygons/lines, which is a nice improvement.
By copying to the back image before setting it as texture, it's not triggering conflict error anymore (not sure if its a good thing or a bug from vulkano). But even with this, stacking many commands in one buffer is very bad. The bottleneck happens in `vulkano::command_buffer::synced::builder::append_command`, in which I think its checking for any conflicts with ALL previous commands. Not sure if it can be improved, but limiting the number of commands in a single command buffer seems to help.
This is much faster than using `CpuAccessibleBuffer`.
This improved performance as well, mostly by using secondary buffers. This reduced the calls to `append_command` on the primary command buffer, which already has a lot. I think this is the main reason for performance improvements.
We can use the channel as fifo, and execute the commands and params as they come in.
Amjad50
force-pushed
the
gpu_multi_thread
branch
from
45f9707
to
7fba16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2.
This is a starting work on making the GPU more performant , but I think it can be improved.