-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added next
, pick
and negate
.
#53
Conversation
Hi @jvduf I have a sort of out-of-band question regarding this PR. If you don't have the time please disregard. I was wondering if you made this PR using the Essentially, since you're the first to submit a new module other than Henrik and I, I'd really really like your first impressions about the process. Be as critical as you feel comfortable, your first impression is important and can only help to make this project better. |
@wraithgar I've got some more coming :) Yes, I used the It was pretty straight forward. The only thing unclear to me was the |
Thanks for doing this! It was one of the utils I was planning on including anyway :) On Thu, Jan 8, 2015 at 2:33 PM, Jeroen van Duffelen
|
@wraithgar @HenrikJoreteg the CI build failed as a result of |
@jvduf the travis config is working for saucelabs, if you update your PR you should see test results |
+1 tests run locally for me |
"name": "amp-next", | ||
"description": "next function part of http://amp.ampersandjs.com.", | ||
"version": "1.0.0", | ||
"author": "Henrik Joreteg <henrik@andyet.net>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the author in this case be "Jeroen van Duffelen"? Or prefer to keep them all as @HenrikJoreteg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should change it so they're not all me, that's definitely a bit silly. However, in this particular case he just dropped in my module: https://www.npmjs.com/package/array-next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I don't really care :) Just added @HenrikJoreteg because it was his original code anyway.
next
utility to fetch the next item in an array.next
, pick
and negate
.
Based on @HenrikJoreteg 's
array-next
module.