Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safer attribute casting. #528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

safer attribute casting. #528

wants to merge 1 commit into from

Conversation

AnalogJ
Copy link
Owner

@AnalogJ AnalogJ commented Oct 17, 2023

fixes #523

@codecov-commenter
Copy link

Codecov Report

Merging #528 (e978676) into master (0febe3f) will decrease coverage by 1.75%.
Report is 71 commits behind head on master.
The diff coverage is 13.69%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   32.54%   30.80%   -1.75%     
==========================================
  Files          54       29      -25     
  Lines        3045     2724     -321     
  Branches       66        0      -66     
==========================================
- Hits          991      839     -152     
+ Misses       2018     1852     -166     
+ Partials       36       33       -3     
Flag Coverage Δ
unittests 30.80% <13.69%> (-1.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webapp/backend/pkg/web/server.go 62.26% <100.00%> (-4.41%) ⬇️
webapp/backend/pkg/config/config.go 0.00% <0.00%> (ø)
webapp/backend/pkg/notify/notify.go 35.39% <0.00%> (-0.37%) ⬇️
webapp/backend/pkg/models/measurements/smart.go 90.96% <50.00%> (-5.07%) ⬇️
...end/pkg/database/scrutiny_repository_migrations.go 0.00% <0.00%> (ø)
webapp/backend/pkg/database/scrutiny_repository.go 11.65% <0.00%> (-0.96%) ⬇️

... and 25 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] interface conversion: interface {} is nil, not int64
2 participants