Translucent Sorting #1340
Translucent Sorting #1340
Conversation
…ve the renderer sort it all out. Picking is broken though.
Source/Core/BoundingSphere.js
Outdated
|
Update CHANGES.md. No need to mention the code changes deep in the renderer, but we should mention that we improved the visual quality of overlapping translucent objects. |
Source/Renderer/Pass.js
Outdated
There was a problem hiding this comment.
Avoid DOC_TBA in new code.
|
Tests and examples are good. |
Source/Scene/Scene.js
Outdated
There was a problem hiding this comment.
The comparison function used with Array.sort is supposed to return (negative/zero/positive) for a (less/equal/greater) b, so I think you want to subtract the distances here.
|
@pjcozzi This is ready for another review. That last commit feels like a hack to me. Something needed to be added to the commands so they weren't sorted. Adding an index made it so that it worked for |
Conflicts: CHANGES.md
|
Let me know when this is ready for another review. I can help design the |
Conflicts: Source/Core/BoundingSphere.js Specs/Core/BoundingSphereSpec.js
Conflicts: Source/Renderer/Pass.js Source/Scene/Scene.js
Conflicts: CHANGES.md
|
Should we close this for now? |
Sorts translucent objects back-to-front for correct ordering. Uses the distance from the command bounding sphere to the camera. We might want to update the other bounding volumes so there can be tighter bounding volumes for commands.