Make most tests pass on IE11 #2859
Conversation
Apparently the IE 11 test failures we've been seeing for months were actually a bug in Cesium where we try to destroy `scene._globeDepth` even when it was undefined. Fixing that allowed IE11 to once again run tests to compeltion without thousands of errors. This then revealed several other spec-only issues that needed to be fixed as well. This brings the overall number of failures down to 5, all of which look rendering related. I'll write up a separate issue for them.
|
Apparently IE will still start randomly failing to create WebGL contexts after repeated runs, but a clean run right after startup seems to pass all but the failures in the linked bug. I merged in master so this is ready for review. |
Source/Scene/Scene.js
Outdated
There was a problem hiding this comment.
Are you sure about this change? context.depthTexture should return a boolean and _globeDepth should be defined if context.depthTexture is true.
See the Scene constructor and implementation for context.depthTexture.
There was a problem hiding this comment.
You are correct, I was thrown off by the name it should probably be something like hasDepthTexture. At one point I thought the _globeDepth check was needed, but I might have been thrown off by the check on line 1839. I removed it and it looks like everything still passes.
|
Both comments have been addressed. |
Merge #2858 first.
Apparently the IE 11 test failures we've been seeing for months were actually a bug in Cesium where we try to destroy
scene._globeDeptheven when it was undefined. Fixing that allowed IE11 to once again run tests to compeltion without thousands of errors. This then revealed several other spec-only issues that needed to be fixed as well.This brings the overall number of failures down to 5, all of which look rendering related. I'll write up a separate issue for them.