Add support for a minimum level to imagery providers #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request #305 is included in this one as well, so merge that one first. |
|
Do we have tests for the |
|
Other than my one outstanding comment, this pull request is OK with me:
|
|
This is not really necessary, and may even be a bad idea before we support rendering a tile in multiple passes. So I'm closing it without merging it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a
getMinimumLevelmethod toImageryProvider. When mapping imagery to terrain,ImageryLayerwill not map imagery less than the specified minimum level. This feature needs to be used with caution, though, because it's easy to bump into the max texture count with it.This addresses an issue raised on the mailing list:
https://groups.google.com/forum/#!topic/cesium-dev/qiQdtnJRW18