Skip to content

Conversation

tfili
Copy link
Contributor

@tfili tfili commented Jun 27, 2019

Fixed factorial to actually work. It would only work if you called it in a loop in order, so I changed the test to not do that

… in a loop in order, so I changed the test to not do that
@cesium-concierge
Copy link

Thanks for the pull request @tfili!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Looks good, factorial actually works now!

Thanks @tfili !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants