Adding support for multisig wallet API (CIP-106) #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: Untested, this is not yet ready to merge!
I have created the initial layout for this feat, I am opening a pull request to get feedback on the last part I need to complete before staring with testing.
to submit a transaction the developers building against CIP-106 need to attach the script, and the correct Key Hashes as "extra signers"
To do this I have 2 options in mind :
A) create a getRefTransaction() , that will return a tx complete with all the requirements that the dev can then expand on or compose with all the other tx they want to perform.
B) During tx.complete() add a check if the Wallet is of type MultisigApi and attach all the required parameters before finalizing.
B seems to be the path with the least amount of friction as devs would be able to use it almost exactly how they would a regular wallet.