Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check slf4j dependencies #3174

Closed
tuomas2 opened this issue Jan 18, 2024 · 3 comments
Closed

Check slf4j dependencies #3174

tuomas2 opened this issue Jan 18, 2024 · 3 comments

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 18, 2024

AndBible/jsword#14 (comment)

  • Check if de.psdev.slf4j-android-logger is coming from some other lib transitively.
  • Write explicit dependency for it in jsword dependency specification.
@tuomas2
Copy link
Contributor Author

tuomas2 commented Jan 25, 2024

Can you @UnasZole check if 309941d looks correct.

@tuomas2 tuomas2 closed this as completed Jan 25, 2024
@github-project-automation github-project-automation bot moved this from Prio 1 to Closed in Tuomas' project board Jan 25, 2024
@UnasZole
Copy link

It seems ok, but why do you exclude("org.slf4j:slf4j-api") ?

slf4j-api is the interface of the logging system.
JSword depends on it because it calls the loggers.
slf4j-android-logger also depends on it because it provides android implementations for these loggers.
So in any case, your application contains slf4j-api, otherwise everything would break.

The only thing your "exclude" does is to force Gradle to take the version of slf4j that is brought transitively by slf4j-android-logger instead of the one from jsword - but in any case, it shouldn't make a difference as far as I know.

@tuomas2
Copy link
Contributor Author

tuomas2 commented Feb 1, 2024

It seems ok, but why do you exclude("org.slf4j:slf4j-api") ?

slf4j-api is the interface of the logging system. JSword depends on it because it calls the loggers. slf4j-android-logger also depends on it because it provides android implementations for these loggers. So in any case, your application contains slf4j-api, otherwise everything would break.

The only thing your "exclude" does is to force Gradle to take the version of slf4j that is brought transitively by slf4j-android-logger instead of the one from jsword - but in any case, it shouldn't make a difference as far as I know.

Thank you for this explanation! Removed exclusion in bb0798f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

No branches or pull requests

2 participants