Skip to content

Ported various hooks #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2020
Merged

Ported various hooks #19

merged 2 commits into from
Jul 21, 2020

Conversation

wintondeshong
Copy link
Contributor

@wintondeshong wintondeshong commented Jul 20, 2020 •
edited
Loading

useDebounce
useOnclickOutside
usePageErrors
useTextOverflow
useWindow

  • n/a Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • Intentional for initial port No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)

@wintondeshong wintondeshong added the enhancement New feature or request label Jul 20, 2020
@wintondeshong wintondeshong self-assigned this Jul 20, 2020
@wintondeshong wintondeshong marked this pull request as ready for review July 20, 2020 21:34
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

❗ No coverage uploaded for pull request head (master@35a527a). Click here to learn what that means.
The diff coverage is n/a.

@wintondeshong wintondeshong merged commit 76bb638 into rsm-hcd:master Jul 21, 2020
@brandongregoryscott
Copy link
Contributor

@all-contributors add @jhugs for review

@allcontributors allcontributors bot mentioned this pull request May 12, 2021
Merged
@allcontributors
Copy link
Contributor

@brandongregoryscott

I've put up a pull request to add @jhugs! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandongregoryscott brandongregoryscott Awaiting requested review from brandongregoryscott

@Stefanie899 Stefanie899 Awaiting requested review from Stefanie899

1 more reviewer

@jhugs jhugs jhugs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wintondeshong wintondeshong

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wintondeshong @brandongregoryscott @jhugs