Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

update dependencies #50

Merged
merged 3 commits into from
Jun 23, 2022
Merged

update dependencies #50

merged 3 commits into from
Jun 23, 2022

Conversation

myty
Copy link
Contributor

@myty myty commented Jun 22, 2022

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)

@myty myty requested review from coykwan, jdahlinrsm and rllowman June 22, 2022 12:43
@myty myty marked this pull request as ready for review June 22, 2022 12:43
Copy link

@jdahlinrsm jdahlinrsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - is the failing test build normal for this project? Timed out?

@myty
Copy link
Contributor Author

myty commented Jun 22, 2022

Looks good - is the failing test build normal for this project? Timed out?

I think we need to also update the github actions to run against a newer Node version, so I'll get that test passing before merging.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #50 (d94edc7) into main (5aacee5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files           2        2           
  Lines          43       43           
  Branches        7        8    +1     
=======================================
  Hits           42       42           
  Misses          1        1           
Impacted Files Coverage Δ
src/utilities/test-utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aacee5...d94edc7. Read the comment docs.

@myty myty merged commit 3b27039 into rsm-hcd:main Jun 23, 2022
@myty myty deleted the feature/update-dependencies branch June 23, 2022 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants